pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart - Issue 2954463002: Refactoring to prepare for kernel based jump targets

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart

Issue 2954463002: Refactoring to prepare for kernel based jump targets (Closed)

Patch Set: Updated cf. comments Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart

diff --git a/pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart b/pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart

index 692676b58445d4f8d4c11e4d0109e089604a7e89..2f8407372dbf4d13b0e42549f90b4a59b1fe844f 100644

--- a/pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart

+++ b/pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart

@@ -105,7 +105,7 @@ class RuntimeTypeGenerator {

TypeTestProperties result = new TypeTestProperties();

if (cls is! ClassElement) return result;

- // TODO(johnniwinther): Handle class entities.

+ // TODO(redemption): Handle class entities.

ClassElement classElement = cls;

assert(classElement.isDeclaration, failedAt(classElement));