Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Unified Diff: pkg/compiler/lib/src/kernel/kernel_strategy.dart

Issue 2954463002: Refactoring to prepare for kernel based jump targets (Closed)
Patch Set: Updated cf. comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/kernel/kernel_strategy.dart
diff --git a/pkg/compiler/lib/src/kernel/kernel_strategy.dart b/pkg/compiler/lib/src/kernel/kernel_strategy.dart
index 541fa8999d484f22da4d7c4587e288ad157136bb..256cfa9d5866166b47f8fba90f4fd24497613137 100644
--- a/pkg/compiler/lib/src/kernel/kernel_strategy.dart
+++ b/pkg/compiler/lib/src/kernel/kernel_strategy.dart
@@ -129,7 +129,7 @@ class KernelFrontEndStrategy implements FrontendStrategy {
@override
SourceSpan spanFromSpannable(Spannable spannable, Entity currentElement) {
- // TODO(johnniwinther): Compute source spans from kernel elements.
+ // TODO(redemption): Compute source spans from kernel elements.
return new SourceSpan(null, null, null);
}
}
@@ -179,7 +179,7 @@ class MirrorsDataBuilderImpl extends MirrorsDataImpl {
@override
void computeMembersNeededForReflection(
ResolutionWorldBuilder worldBuilder, ClosedWorld closedWorld) {
- // TODO(johnniwinther): Support dart:mirrors.
+ // TODO(redemption): Support dart:mirrors.
createImmutableSets();
}
@@ -204,7 +204,7 @@ class MirrorsResolutionAnalysisImpl implements MirrorsResolutionAnalysis {
@override
MirrorsCodegenAnalysis close() {
- // TODO(johnniwinther): Implement this.
+ // TODO(redemption): Implement this.
return new MirrorsCodegenAnalysisImpl();
}
@@ -215,12 +215,12 @@ class MirrorsResolutionAnalysisImpl implements MirrorsResolutionAnalysis {
class MirrorsCodegenAnalysisImpl implements MirrorsCodegenAnalysis {
@override
int get preMirrorsMethodCount {
- // TODO(johnniwinther): Implement this.
+ // TODO(redemption): Implement this.
return null;
}
@override
void onQueueEmpty(Enqueuer enqueuer, Iterable<ClassEntity> recentClasses) {
- // TODO(johnniwinther): Implement this.
+ // TODO(redemption): Implement this.
}
}
« no previous file with comments | « pkg/compiler/lib/src/kernel/kernel_backend_strategy.dart ('k') | pkg/compiler/lib/src/kernel/native_basic_data.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698