Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Unified Diff: pkg/compiler/lib/src/js_emitter/metadata_collector.dart

Issue 2954463002: Refactoring to prepare for kernel based jump targets (Closed)
Patch Set: Updated cf. comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_emitter/metadata_collector.dart
diff --git a/pkg/compiler/lib/src/js_emitter/metadata_collector.dart b/pkg/compiler/lib/src/js_emitter/metadata_collector.dart
index e2573c6407bd9a0d4ed788171f2fa9628c564ea9..383403fb6c71313c5119e71651f8221f9b9c7c61 100644
--- a/pkg/compiler/lib/src/js_emitter/metadata_collector.dart
+++ b/pkg/compiler/lib/src/js_emitter/metadata_collector.dart
@@ -194,7 +194,7 @@ class MetadataCollector implements jsAst.TokenFinalizer {
!_mirrorsData.isClassReferencedFromMirrorSystem(cls)) {
return null;
}
- // TODO(johnniwinther): Handle class entities.
+ // TODO(redemption): Handle class entities.
ClassElement element = cls;
return _buildMetadataFunction(element);
}
@@ -203,14 +203,14 @@ class MetadataCollector implements jsAst.TokenFinalizer {
if (!_mirrorsData.mustRetainMetadata) {
return false;
}
- // TODO(johnniwinther): Handle member entities.
+ // TODO(redemption): Handle member entities.
MemberElement element = member;
return _mirrorsData.isMemberReferencedFromMirrorSystem(element);
}
jsAst.Fun buildFieldMetadataFunction(FieldEntity field) {
if (!_mustEmitMetadataForMember(field)) return null;
- // TODO(johnniwinther): Handle field entities.
+ // TODO(redemption): Handle field entities.
FieldElement element = field;
return _buildMetadataFunction(element);
}

Powered by Google App Engine
This is Rietveld 408576698