Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Unified Diff: pkg/compiler/lib/src/ssa/kernel_impact.dart

Issue 2954463002: Refactoring to prepare for kernel based jump targets (Closed)
Patch Set: Updated cf. comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart ('k') | pkg/compiler/lib/src/ssa/loop_handler.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/ssa/kernel_impact.dart
diff --git a/pkg/compiler/lib/src/ssa/kernel_impact.dart b/pkg/compiler/lib/src/ssa/kernel_impact.dart
index 6fa759ed7c59284a86b9d1dd3efc8d19077e0f7d..4e497c0be91d9930ccafbbc293235dd6f8bf7877 100644
--- a/pkg/compiler/lib/src/ssa/kernel_impact.dart
+++ b/pkg/compiler/lib/src/ssa/kernel_impact.dart
@@ -124,7 +124,7 @@ class KernelImpactBuilder extends ir.Visitor {
}
if (field.isInstanceMember &&
elementAdapter.isNativeClass(field.enclosingClass)) {
- // TODO(johnniwinther): Provide the correct value for [isJsInterop].
+ // TODO(redemption): Provide the correct value for [isJsInterop].
impactBuilder.registerNativeData(elementAdapter
.getNativeBehaviorForFieldLoad(field, isJsInterop: false));
impactBuilder.registerNativeData(
@@ -165,7 +165,7 @@ class KernelImpactBuilder extends ir.Visitor {
handleAsyncMarker(procedure.function.asyncMarker);
if (procedure.isExternal &&
!elementAdapter.isForeignLibrary(procedure.enclosingLibrary)) {
- // TODO(johnniwinther): Provide the correct value for [isJsInterop].
+ // TODO(redemption): Provide the correct value for [isJsInterop].
impactBuilder.registerNativeData(elementAdapter
.getNativeBehaviorForMethod(procedure, isJsInterop: false));
}
« no previous file with comments | « pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart ('k') | pkg/compiler/lib/src/ssa/loop_handler.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698