Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1163)

Unified Diff: pkg/compiler/lib/src/js_model/elements.dart

Issue 2954463002: Refactoring to prepare for kernel based jump targets (Closed)
Patch Set: Updated cf. comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_model/elements.dart
diff --git a/pkg/compiler/lib/src/js_model/elements.dart b/pkg/compiler/lib/src/js_model/elements.dart
index 5d12e2c2abca0cb7ebe68a9b538cacbc385147a1..b53b6a5cbd2553fe6081e64a8cc4510889ecb271 100644
--- a/pkg/compiler/lib/src/js_model/elements.dart
+++ b/pkg/compiler/lib/src/js_model/elements.dart
@@ -103,7 +103,7 @@ class JsToFrontendMapImpl implements JsToFrontendMap {
} else if (member.isConstructor) {
ConstructorEntity constructor = member;
if (constructor.isFactoryConstructor) {
- // TODO(johnniwinther): This should be a JFunction.
+ // TODO(redemption): This should be a JFunction.
newMember = new JFactoryConstructor(_toBackendMember.length, cls,
memberName, constructor.parameterStructure,
isExternal: constructor.isExternal,
« no previous file with comments | « pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart ('k') | pkg/compiler/lib/src/kernel/element_map.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698