pkg/compiler/lib/src/js_model/elements.dart - Issue 2954463002: Refactoring to prepare for kernel based jump targets

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_model/elements.dart

Issue 2954463002: Refactoring to prepare for kernel based jump targets (Closed)

Patch Set: Updated cf. comments Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/js_model/elements.dart

diff --git a/pkg/compiler/lib/src/js_model/elements.dart b/pkg/compiler/lib/src/js_model/elements.dart

index 5d12e2c2abca0cb7ebe68a9b538cacbc385147a1..b53b6a5cbd2553fe6081e64a8cc4510889ecb271 100644

--- a/pkg/compiler/lib/src/js_model/elements.dart

+++ b/pkg/compiler/lib/src/js_model/elements.dart

@@ -103,7 +103,7 @@ class JsToFrontendMapImpl implements JsToFrontendMap {

} else if (member.isConstructor) {

ConstructorEntity constructor = member;

if (constructor.isFactoryConstructor) {

- // TODO(johnniwinther): This should be a JFunction.

+ // TODO(redemption): This should be a JFunction.

newMember = new JFactoryConstructor(_toBackendMember.length, cls,

memberName, constructor.parameterStructure,

isExternal: constructor.isExternal,