Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Side by Side Diff: pkg/compiler/lib/src/js_model/elements.dart

Issue 2954463002: Refactoring to prepare for kernel based jump targets (Closed)
Patch Set: Updated cf. comments Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library dart2js.js_model.elements; 5 library dart2js.js_model.elements;
6 6
7 import '../common_elements.dart'; 7 import '../common_elements.dart';
8 import '../constants/constant_system.dart'; 8 import '../constants/constant_system.dart';
9 import '../constants/values.dart'; 9 import '../constants/values.dart';
10 import '../elements/elements.dart'; 10 import '../elements/elements.dart';
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
96 if (member.isField) { 96 if (member.isField) {
97 FieldEntity field = member; 97 FieldEntity field = member;
98 newMember = new JField( 98 newMember = new JField(
99 _toBackendMember.length, library, cls, memberName, 99 _toBackendMember.length, library, cls, memberName,
100 isStatic: field.isStatic, 100 isStatic: field.isStatic,
101 isAssignable: field.isAssignable, 101 isAssignable: field.isAssignable,
102 isConst: field.isConst); 102 isConst: field.isConst);
103 } else if (member.isConstructor) { 103 } else if (member.isConstructor) {
104 ConstructorEntity constructor = member; 104 ConstructorEntity constructor = member;
105 if (constructor.isFactoryConstructor) { 105 if (constructor.isFactoryConstructor) {
106 // TODO(johnniwinther): This should be a JFunction. 106 // TODO(redemption): This should be a JFunction.
107 newMember = new JFactoryConstructor(_toBackendMember.length, cls, 107 newMember = new JFactoryConstructor(_toBackendMember.length, cls,
108 memberName, constructor.parameterStructure, 108 memberName, constructor.parameterStructure,
109 isExternal: constructor.isExternal, 109 isExternal: constructor.isExternal,
110 isConst: constructor.isConst, 110 isConst: constructor.isConst,
111 isFromEnvironmentConstructor: 111 isFromEnvironmentConstructor:
112 constructor.isFromEnvironmentConstructor); 112 constructor.isFromEnvironmentConstructor);
113 } else { 113 } else {
114 newMember = new JGenerativeConstructor(_toBackendMember.length, cls, 114 newMember = new JGenerativeConstructor(_toBackendMember.length, cls,
115 memberName, constructor.parameterStructure, 115 memberName, constructor.parameterStructure,
116 isExternal: constructor.isExternal, isConst: constructor.isConst); 116 isExternal: constructor.isExternal, isConst: constructor.isConst);
(...skipping 1739 matching lines...) Expand 10 before | Expand all | Expand 10 after
1856 @override 1856 @override
1857 ClassEntity get numClass => _map.toBackendClass(_commonElements.numClass); 1857 ClassEntity get numClass => _map.toBackendClass(_commonElements.numClass);
1858 1858
1859 @override 1859 @override
1860 ClassEntity get boolClass => _map.toBackendClass(_commonElements.boolClass); 1860 ClassEntity get boolClass => _map.toBackendClass(_commonElements.boolClass);
1861 1861
1862 @override 1862 @override
1863 FunctionEntity get throwUnsupportedError => 1863 FunctionEntity get throwUnsupportedError =>
1864 _map.toBackendMember(_commonElements.throwUnsupportedError); 1864 _map.toBackendMember(_commonElements.throwUnsupportedError);
1865 } 1865 }
OLDNEW
« no previous file with comments | « pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart ('k') | pkg/compiler/lib/src/kernel/element_map.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698