Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Unified Diff: pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart

Issue 2954463002: Refactoring to prepare for kernel based jump targets (Closed)
Patch Set: Updated cf. comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart
diff --git a/pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart b/pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart
index 01b1c65980928a0cf21bacb2f3649ef64507c844..994e24433ca86b0236896319e6bf266d0aab2b97 100644
--- a/pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart
+++ b/pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart
@@ -525,7 +525,7 @@ class ProgramBuilder {
.forEach((LibraryEntity library, List<ClassEntity> classElements, _) {
for (ClassEntity cls in classElements) {
if (_nativeData.isJsInteropClass(cls)) {
- // TODO(johnniwinther): Handle class entities.
+ // TODO(redemption): Handle class entities.
ClassElement e = cls;
e.declaration.forEachMember((_, _member) {
MemberElement member = _member;
@@ -755,7 +755,7 @@ class ProgramBuilder {
if (!onlyForRti && !_elementEnvironment.isMixinApplication(cls)) {
_elementEnvironment.forEachClassMember(cls, visitMember);
if (cls is ClassElement) {
- // TODO(johnniwinther): Support constructor bodies for entities.
+ // TODO(redemption): Support constructor bodies for entities.
cls.forEachConstructorBody((ConstructorBodyElement constructorBody) =>
visitMember(cls, constructorBody));
}
@@ -947,7 +947,7 @@ class ProgramBuilder {
int requiredParameterCount;
var /* List | Map */ optionalParameterDefaultValues;
if (canBeApplied || canBeReflected) {
- // TODO(johnniwinther): Handle function entities.
+ // TODO(redemption): Handle function entities.
MethodElement method = element;
FunctionSignature signature = method.functionSignature;
requiredParameterCount = signature.requiredParameterCount;
@@ -1155,7 +1155,7 @@ class ProgramBuilder {
int requiredParameterCount;
var /* List | Map */ optionalParameterDefaultValues;
if (canBeApplied || canBeReflected) {
- // TODO(johnniwinther): Support entities;
+ // TODO(redemption): Support entities;
MethodElement method = element;
FunctionSignature signature = method.functionSignature;
requiredParameterCount = signature.requiredParameterCount;
« no previous file with comments | « pkg/compiler/lib/src/js_emitter/metadata_collector.dart ('k') | pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698