Refactoring to prepare for kernel based jump targets

pkg/compiler/lib/src/kernel/kernel_backend_strategy.dart

 // Copyright (c) 2017, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library dart2js.kernel.backend_strategy;
 
 import 'package:kernel/ast.dart' as ir;
 
 import '../backend_strategy.dart';
 import '../closure.dart';
@@ skipping 280 matching lines @@
     _members.add(member);
   }
 
   @override
   void leaveInlinedMember(MemberEntity member) {
     assert(member == currentMember);
     _members.removeLast();
   }
 
   @override
-  JumpTarget getJumpTarget(ir.TreeNode node, {bool isContinueTarget: false}) {
-    // TODO(johnniwinther): Support jump targets.
+  JumpTarget getJumpTargetForBreak(ir.BreakStatement node) {
+    throw new UnimplementedError('KernelToLocalsMapImpl.getJumpTargetForBreak');
+  }
+
+  @override
+  JumpTarget getJumpTargetForContinueSwitch(ir.ContinueSwitchStatement node) {
+    throw new UnimplementedError(
+        'KernelToLocalsMapImpl.getJumpTargetForContinueSwitch');
+  }
+
+  @override
+  JumpTarget getJumpTargetForSwitchCase(ir.SwitchCase node) {
+    throw new UnimplementedError(
+        'KernelToLocalsMapImpl.getJumpTargetForSwitchCase');
+  }
+
+  @override
+  JumpTarget getJumpTargetForDo(ir.DoStatement node) {
+    // TODO(johnniwinther): Support do statement as jump target.

[Siggi Cherem (dart-lang), 2017/06/23 19:25:59]

null vs throw is based on whether hello-world hits each case?

I think it will help us later on to start adding a conditional throw that we can
easily find. OR use a keyword in all TODO comments that relate to completeness.

[Johnni Winther, 2017/06/26 07:57:36]

Used TODO(redemption) in all such places instead.

     return null;
   }
 
+  @override
+  JumpTarget getJumpTargetForLabel(ir.LabeledStatement node) {
+    throw new UnimplementedError('KernelToLocalsMapImpl.getJumpTargetForLabel');
+  }
+
+  @override
+  JumpTarget getJumpTargetForSwitch(ir.SwitchStatement node) {
+    throw new UnimplementedError(
+        'KernelToLocalsMapImpl.getJumpTargetForSwitch');
+  }
+
+  @override
+  JumpTarget getJumpTargetForFor(ir.ForStatement node) {
+    // TODO(johnniwinther): Support for statement as jump target.
+    return null;
+  }
+
+  @override
+  JumpTarget getJumpTargetForForIn(ir.ForInStatement node) {
+    // TODO(johnniwinther): Support for-in statement as jump target.
+    return null;
+  }
+
+  @override
+  JumpTarget getJumpTargetForWhile(ir.WhileStatement node) {
+    // TODO(johnniwinther): Support while statement as jump target.
+    return null;
+  }
+
   @override
   Local getLocal(ir.VariableDeclaration node) {
     return _map.putIfAbsent(node, () {
       return new KLocal(node.name, currentMember);
     });
   }
 
   @override
   LoopClosureRepresentationInfo getClosureRepresentationInfoForLoop(
       ClosureDataLookup closureLookup, ir.TreeNode node) {
@@ skipping 65 matching lines @@
   Iterable<ClassEntity> sortClasses(Iterable<ClassEntity> classes) {
     return classes.toList()
       ..sort((ClassEntity a, ClassEntity b) {
         int r = _compareLibraries(a.library, b.library);
         if (r != 0) return r;
         return _compareNodes(
             a, elementMap.getClassNode(a), b, elementMap.getClassNode(b));
       });
   }
 }