pkg/compiler/lib/src/js_emitter/full_emitter/container_builder.dart - Issue 2954463002: Refactoring to prepare for kernel based jump targets

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_emitter/full_emitter/container_builder.dart

Issue 2954463002: Refactoring to prepare for kernel based jump targets (Closed)

Patch Set: Updated cf. comments Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/compiler/lib/src/js_emitter/full_emitter/class_emitter.dart ('k') | pkg/compiler/lib/src/js_emitter/metadata_collector.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/compiler/lib/src/js_emitter/full_emitter/container_builder.dart

diff --git a/pkg/compiler/lib/src/js_emitter/full_emitter/container_builder.dart b/pkg/compiler/lib/src/js_emitter/full_emitter/container_builder.dart

index 53a4777d8b2883a9ee6adc95f4410eb2faea3211..e9c2c07431f461f1f1d6aef00ca8d767041d2a2c 100644

--- a/pkg/compiler/lib/src/js_emitter/full_emitter/container_builder.dart

+++ b/pkg/compiler/lib/src/js_emitter/full_emitter/container_builder.dart

@@ -147,7 +147,7 @@ class ContainerBuilder extends CodeEmitterHelper {

..addAll(task.metadataCollector.reifyDefaultArguments(member));

if (canBeReflected || canBeApplied) {

- // TODO(johnniwinther): Support entities.

+ // TODO(redemption): Support entities.

MethodElement method = member;

method.functionSignature.forEachParameter((Element parameter) {

expressions.add(task.metadataCollector.reifyName(parameter.name));