Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 2846303002: Replace ASSERT with DCHECK in platform/ (Closed)

Created:
3 years, 7 months ago by pilgrim_google
Modified:
3 years, 7 months ago
Reviewers:
haraken, tkent
CC:
Mads Ager (chromium), ajuma+watch_chromium.org, darktears, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-events_chromium.org, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, dcheng, dglazkov+blink, dshwang, drott+blinkwatch_chromium.org, krit, dtapuska+blinkwatch_chromium.org, eae+blinkwatch, Eric Willigers, fmalita+watch_chromium.org, Justin Novosad, kinuko+watch, kouhei+heap_chromium.org, mac-reviews_chromium.org, oilpan-reviews, pdr+graphicswatchlist_chromium.org, rjwright, rwlbuis, Stephen Chennney, shans, tommyw+watchlist_chromium.org, jsbell
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace ASSERT with DCHECK in platform/ This CL only affects instances of ASSERT() that have unary parameters with no (in)equality checks. BUG=707638 Review-Url: https://codereview.chromium.org/2846303002 Cr-Commit-Position: refs/heads/master@{#468346} Committed: https://chromium.googlesource.com/chromium/src/+/41a37b9e82b9f33982f6add34906fed081303ca9

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+215 lines, -208 lines) Patch
M third_party/WebKit/Source/platform/AsyncMethodRunner.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/Crypto.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/DateComponents.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/Decimal.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/Decimal.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/DecimalTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/DragImageTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/EventDispatchForbiddenScope.h View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/Language.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/LayoutTestSupport.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/Length.h View 4 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/Length.cpp View 4 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/platform/LifecycleContextTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/LifecycleNotifier.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/LinkHash.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/PODRedBlackTree.h View 5 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/PluginScriptForbiddenScope.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/Timer.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/WebThreadSupportingGC.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/blob/BlobURL.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/geometry/FloatPolygon.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/geometry/FloatPolygon.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/geometry/TransformState.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/geometry/TransformState.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/ThreadState.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/image-encoders/PNGImageEncoder.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/mac/ScrollAnimatorMac.mm View 7 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/mediastream/MediaStreamCenter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/mediastream/MediaStreamDescriptor.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/mediastream/MediaStreamSource.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/mediastream/MediaStreamWebAudioSource.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/mhtml/ArchiveResource.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/mhtml/MHTMLArchive.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/network/FormDataEncoder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollAnimator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/scroll/Scrollbar.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollbarThemeMac.mm View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/testing/WebLayerTreeViewImplForTesting.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/transforms/ScaleTransformOperation.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/transforms/TransformationMatrix.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/transforms/TranslateTransformOperation.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/weborigin/SecurityOrigin.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/weborigin/SecurityPolicy.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/wtf/AssertionsTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/wtf/dtoa/bignum.cc View 6 chunks +103 lines, -96 lines 0 comments Download
M third_party/WebKit/Source/platform/wtf/dtoa/bignum-dtoa.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/wtf/dtoa/double-conversion.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/wtf/dtoa/fast-dtoa.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/wtf/text/StringImplCF.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (10 generated)
pilgrim_google
3 years, 7 months ago (2017-04-28 18:10:44 UTC) #2
haraken
LGTM
3 years, 7 months ago (2017-04-29 02:12:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2846303002/20001
3 years, 7 months ago (2017-05-01 15:29:39 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-01 17:35:55 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/41a37b9e82b9f33982f6add34906...

Powered by Google App Engine
This is Rietveld 408576698