Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Unified Diff: third_party/WebKit/Source/platform/weborigin/SecurityPolicy.cpp

Issue 2846303002: Replace ASSERT with DCHECK in platform/ (Closed)
Patch Set: rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/weborigin/SecurityPolicy.cpp
diff --git a/third_party/WebKit/Source/platform/weborigin/SecurityPolicy.cpp b/third_party/WebKit/Source/platform/weborigin/SecurityPolicy.cpp
index 415260a9b524732c8d1754581020b58568a10a2c..ad2b98b7961545e0156d03c8aa431e5fe0463f93 100644
--- a/third_party/WebKit/Source/platform/weborigin/SecurityPolicy.cpp
+++ b/third_party/WebKit/Source/platform/weborigin/SecurityPolicy.cpp
@@ -92,7 +92,7 @@ Referrer SecurityPolicy::GenerateReferrer(ReferrerPolicy referrer_policy,
}
if (referrer == Referrer::NoReferrer())
return Referrer(Referrer::NoReferrer(), referrer_policy_no_default);
- ASSERT(!referrer.IsEmpty());
+ DCHECK(!referrer.IsEmpty());
KURL referrer_url = KURL(KURL(), referrer);
String scheme = referrer_url.Protocol();
@@ -202,8 +202,8 @@ void SecurityPolicy::AddOriginAccessWhitelistEntry(
const String& destination_protocol,
const String& destination_domain,
bool allow_destination_subdomains) {
- ASSERT(IsMainThread());
- ASSERT(!source_origin.IsUnique());
+ DCHECK(IsMainThread());
+ DCHECK(!source_origin.IsUnique());
if (source_origin.IsUnique())
return;
@@ -225,8 +225,8 @@ void SecurityPolicy::RemoveOriginAccessWhitelistEntry(
const String& destination_protocol,
const String& destination_domain,
bool allow_destination_subdomains) {
- ASSERT(IsMainThread());
- ASSERT(!source_origin.IsUnique());
+ DCHECK(IsMainThread());
+ DCHECK(!source_origin.IsUnique());
if (source_origin.IsUnique())
return;
@@ -252,7 +252,7 @@ void SecurityPolicy::RemoveOriginAccessWhitelistEntry(
}
void SecurityPolicy::ResetOriginAccessWhitelists() {
- ASSERT(IsMainThread());
+ DCHECK(IsMainThread());
GetOriginAccessMap().clear();
}

Powered by Google App Engine
This is Rietveld 408576698