third_party/WebKit/Source/platform/wtf/AssertionsTest.cpp - Issue 2846303002: Replace ASSERT with DCHECK in platform/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/wtf/AssertionsTest.cpp

Issue 2846303002: Replace ASSERT with DCHECK in platform/ (Closed)

Patch Set: rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/wtf/AssertionsTest.cpp

diff --git a/third_party/WebKit/Source/platform/wtf/AssertionsTest.cpp b/third_party/WebKit/Source/platform/wtf/AssertionsTest.cpp

index 029e3a5dbe511ef14adad99333b6c32d10c6b241..ee6a2e1297454c81c9e81fef800163b83bdf345d 100644

--- a/third_party/WebKit/Source/platform/wtf/AssertionsTest.cpp

+++ b/third_party/WebKit/Source/platform/wtf/AssertionsTest.cpp

@@ -11,7 +11,7 @@

namespace WTF {

TEST(AssertionsTest, Assertions) {

- ASSERT(true);

+ DCHECK(true);

#if DCHECK_IS_ON()

EXPECT_DEATH_IF_SUPPORTED(ASSERT(false), "");

EXPECT_DEATH_IF_SUPPORTED(NOTREACHED(), "");