third_party/WebKit/Source/platform/scroll/ScrollAnimator.cpp - Issue 2846303002: Replace ASSERT with DCHECK in platform/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/scroll/ScrollAnimator.cpp

Issue 2846303002: Replace ASSERT with DCHECK in platform/ (Closed)

Patch Set: rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/scroll/ScrollAnimator.cpp

diff --git a/third_party/WebKit/Source/platform/scroll/ScrollAnimator.cpp b/third_party/WebKit/Source/platform/scroll/ScrollAnimator.cpp

index 3fb3c9e214ad5354356406eb6729fadf2557fa01..bc725456b56050e63b9d2ba70f17fd37c68cbf1d 100644

--- a/third_party/WebKit/Source/platform/scroll/ScrollAnimator.cpp

+++ b/third_party/WebKit/Source/platform/scroll/ScrollAnimator.cpp

@@ -147,7 +147,7 @@ bool ScrollAnimator::WillAnimateToOffset(const ScrollOffset& target_offset) {

if (run_state_ == RunState::kWaitingToCancelOnCompositor ||

run_state_ == RunState::kWaitingToCancelOnCompositorButNewScroll) {

- ASSERT(animation_curve_);

+ DCHECK(animation_curve_);

target_offset_ = target_offset;

if (RegisterAndScheduleAnimation())

run_state_ = RunState::kWaitingToCancelOnCompositorButNewScroll;