third_party/WebKit/Source/platform/network/FormDataEncoder.cpp - Issue 2846303002: Replace ASSERT with DCHECK in platform/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/network/FormDataEncoder.cpp

Issue 2846303002: Replace ASSERT with DCHECK in platform/ (Closed)

Patch Set: rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/network/FormDataEncoder.cpp

diff --git a/third_party/WebKit/Source/platform/network/FormDataEncoder.cpp b/third_party/WebKit/Source/platform/network/FormDataEncoder.cpp

index ebf5460133e0f0cc1d1d55664e1095d344a81817..04f45ec3a442322ea4f374bbffd627674da90de2 100644

--- a/third_party/WebKit/Source/platform/network/FormDataEncoder.cpp

+++ b/third_party/WebKit/Source/platform/network/FormDataEncoder.cpp

@@ -79,7 +79,7 @@ static void AppendQuotedString(Vector<char>& buffer, const CString& string) {

WTF::TextEncoding FormDataEncoder::EncodingFromAcceptCharset(

const String& accept_charset,

const WTF::TextEncoding& fallback_encoding) {

- ASSERT(fallback_encoding.IsValid());

+ DCHECK(fallback_encoding.IsValid());

String normalized_accept_charset = accept_charset;

normalized_accept_charset.Replace(',', ' ');