third_party/WebKit/Source/platform/wtf/dtoa/bignum-dtoa.cc - Issue 2846303002: Replace ASSERT with DCHECK in platform/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/wtf/dtoa/bignum-dtoa.cc

Issue 2846303002: Replace ASSERT with DCHECK in platform/ (Closed)

Patch Set: rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/wtf/dtoa/bignum-dtoa.cc

diff --git a/third_party/WebKit/Source/platform/wtf/dtoa/bignum-dtoa.cc b/third_party/WebKit/Source/platform/wtf/dtoa/bignum-dtoa.cc

index 5e1e143f43b4d7c87d337eae8ad70f7be5bc8259..bee7cf3c52b8647ea713ef757370164b42a6608b 100644

--- a/third_party/WebKit/Source/platform/wtf/dtoa/bignum-dtoa.cc

+++ b/third_party/WebKit/Source/platform/wtf/dtoa/bignum-dtoa.cc

@@ -88,7 +88,7 @@ namespace double_conversion {

void BignumDtoa(double v, BignumDtoaMode mode, int requested_digits,

Vector<char> buffer, int* length, int* decimal_point) {

ASSERT(v > 0);

- ASSERT(!Double(v).IsSpecial());

+ DCHECK(!Double(v).IsSpecial());

uint64_t significand = Double(v).Significand();

bool is_even = (significand & 1) == 0;

int exponent = Double(v).Exponent();