third_party/WebKit/Source/platform/LifecycleNotifier.h - Issue 2846303002: Replace ASSERT with DCHECK in platform/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/LifecycleNotifier.h

Issue 2846303002: Replace ASSERT with DCHECK in platform/ (Closed)

Patch Set: rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/LifecycleNotifier.h

diff --git a/third_party/WebKit/Source/platform/LifecycleNotifier.h b/third_party/WebKit/Source/platform/LifecycleNotifier.h

index c9830a8497a3edf071c5991e739aee647d643a60..56ea17995b8f45c62f0d36bab783434d96db9e15 100644

--- a/third_party/WebKit/Source/platform/LifecycleNotifier.h

+++ b/third_party/WebKit/Source/platform/LifecycleNotifier.h

@@ -81,7 +81,7 @@ template <typename T, typename Observer>

inline LifecycleNotifier<T, Observer>::~LifecycleNotifier() {

// FIXME: Enable the following ASSERT. Also see a FIXME in

// Document::detachLayoutTree().

- // ASSERT(!m_observers.size());

+ // DCHECK(!m_observers.size());

}

// Determine if |contextDestroyed(Observer*) is a public method on