third_party/WebKit/Source/platform/mediastream/MediaStreamDescriptor.cpp - Issue 2846303002: Replace ASSERT with DCHECK in platform/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/mediastream/MediaStreamDescriptor.cpp

Issue 2846303002: Replace ASSERT with DCHECK in platform/ (Closed)

Patch Set: rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/mediastream/MediaStreamCenter.cpp ('k') | third_party/WebKit/Source/platform/mediastream/MediaStreamSource.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/mediastream/MediaStreamDescriptor.cpp

diff --git a/third_party/WebKit/Source/platform/mediastream/MediaStreamDescriptor.cpp b/third_party/WebKit/Source/platform/mediastream/MediaStreamDescriptor.cpp

index 246d4c21bce465b7e6ea1376a0e08b22022e6ced..da5379d233325b0cece746b49f5d9c0d83a099bc 100644

--- a/third_party/WebKit/Source/platform/mediastream/MediaStreamDescriptor.cpp

+++ b/third_party/WebKit/Source/platform/mediastream/MediaStreamDescriptor.cpp

@@ -104,7 +104,7 @@ MediaStreamDescriptor::MediaStreamDescriptor(

const MediaStreamSourceVector& audio_sources,

const MediaStreamSourceVector& video_sources)

: client_(nullptr), id_(id), active_(true) {

- ASSERT(id_.length());

+ DCHECK(id_.length());

for (size_t i = 0; i < audio_sources.size(); i++)

audio_components_.push_back(MediaStreamComponent::Create(audio_sources[i]));

@@ -117,7 +117,7 @@ MediaStreamDescriptor::MediaStreamDescriptor(

const MediaStreamComponentVector& audio_components,

const MediaStreamComponentVector& video_components)

: client_(nullptr), id_(id), active_(true) {

- ASSERT(id_.length());

+ DCHECK(id_.length());

for (MediaStreamComponentVector::const_iterator iter =

audio_components.begin();

iter != audio_components.end(); ++iter)