Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Side by Side Diff: third_party/WebKit/Source/platform/geometry/TransformState.h

Issue 2846303002: Replace ASSERT with DCHECK in platform/ (Closed)
Patch Set: rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Apple Inc. All rights reserved. 2 * Copyright (C) 2011 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 77 matching lines...) Expand 10 before | Expand all | Expand 10 after
88 88
89 TransformState& operator=(const TransformState&); 89 TransformState& operator=(const TransformState&);
90 90
91 // Note: this overrides the quad and ignores any accumulatedOffset. 91 // Note: this overrides the quad and ignores any accumulatedOffset.
92 // If it's desired to include the offset, call flatten() first. 92 // If it's desired to include the offset, call flatten() first.
93 void SetQuad(const FloatQuad& quad) { 93 void SetQuad(const FloatQuad& quad) {
94 DCHECK(!accumulating_transform_); 94 DCHECK(!accumulating_transform_);
95 // FIXME: this assumes that the quad being added is in the coordinate system 95 // FIXME: this assumes that the quad being added is in the coordinate system
96 // of the current state. This breaks if we're simultaneously mapping a 96 // of the current state. This breaks if we're simultaneously mapping a
97 // point. https://bugs.webkit.org/show_bug.cgi?id=106680 97 // point. https://bugs.webkit.org/show_bug.cgi?id=106680
98 ASSERT(!map_point_); 98 DCHECK(!map_point_);
99 accumulated_offset_ = LayoutSize(); 99 accumulated_offset_ = LayoutSize();
100 last_planar_quad_ = quad; 100 last_planar_quad_ = quad;
101 } 101 }
102 102
103 void Move(LayoutUnit x, 103 void Move(LayoutUnit x,
104 LayoutUnit y, 104 LayoutUnit y,
105 TransformAccumulation accumulate = kFlattenTransform) { 105 TransformAccumulation accumulate = kFlattenTransform) {
106 Move(LayoutSize(x, y), accumulate); 106 Move(LayoutSize(x, y), accumulate);
107 } 107 }
108 108
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
148 LayoutSize accumulated_offset_; 148 LayoutSize accumulated_offset_;
149 bool accumulating_transform_; 149 bool accumulating_transform_;
150 bool force_accumulating_transform_; 150 bool force_accumulating_transform_;
151 bool map_point_, map_quad_; 151 bool map_point_, map_quad_;
152 TransformDirection direction_; 152 TransformDirection direction_;
153 }; 153 };
154 154
155 } // namespace blink 155 } // namespace blink
156 156
157 #endif // TransformState_h 157 #endif // TransformState_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698