Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/fonts

Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/fonts

Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED
with DCHECK_op, CHECK_op, and NOTREACHED respectively in
third_party/WebKit/Source/platform/fonts

BUG=707657
Review-Url: https://codereview.chromium.org/2807913002
Cr-Commit-Position: refs/heads/master@{#463850}
Committed: https://chromium.googlesource.com/chromium/src/+/e5e496d06dc34dd313677ad3cd125d719d838830

[Hwanseung Lee, 2017-04-08 05:52:57]

The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-08 05:53:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-08 06:07:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-08 06:07:37]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Hwanseung Lee, 2017-04-08 08:30:13]

The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-08 08:30:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-08 09:54:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-08 09:54:26]

Dry run: This issue passed the CQ dry run.

[Hwanseung Lee, 2017-04-08 10:00:09]

hs1217.lee@samsung.com changed reviewers:
+ drott@chromium.org, eae@chromium.org, tkent@chromium.org

[Hwanseung Lee, 2017-04-08 10:00:09]

PTAL, thank you.

[eae, 2017-04-09 07:30:12]

LGTM

[Hwanseung Lee, 2017-04-09 08:21:43]

The CQ bit was checked by hs1217.lee@samsung.com

[commit-bot: I haz the power, 2017-04-09 08:21:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-09 21:55:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-09 21:55:50]

Failed to apply patch for third_party/WebKit/Source/platform/fonts/Font.cpp:
While running git apply --index -3 -p1;
  error: patch failed: third_party/WebKit/Source/platform/fonts/Font.cpp:159
  Falling back to three-way merge...
  Applied patch to 'third_party/WebKit/Source/platform/fonts/Font.cpp' with
conflicts.
  U third_party/WebKit/Source/platform/fonts/Font.cpp

Patch:       third_party/WebKit/Source/platform/fonts/Font.cpp
Index: third_party/WebKit/Source/platform/fonts/Font.cpp
diff --git a/third_party/WebKit/Source/platform/fonts/Font.cpp
b/third_party/WebKit/Source/platform/fonts/Font.cpp
index
2d9752f362ae77cd4fa7390a238903bba647f611..57a698dc196b814c3a8af97df300e9a558898d0b
100644
--- a/third_party/WebKit/Source/platform/fonts/Font.cpp
+++ b/third_party/WebKit/Source/platform/fonts/Font.cpp
@@ -159,7 +159,7 @@ bool Font::drawBidiText(PaintCanvas* canvas,
 
   // sub-run painting is not supported for Bidi text.
   const TextRun& run = runInfo.run;
-  ASSERT((runInfo.from == 0) && (runInfo.to == run.length()));
+  DCHECK((runInfo.from == 0) && (runInfo.to == run.length()));
   BidiResolver<TextRunIterator, BidiCharacterRun> bidiResolver;
   bidiResolver.setStatus(
       BidiStatus(run.direction(), run.directionalOverride()));

[tkent, 2017-04-09 23:13:23]

https://codereview.chromium.org/2807913002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/fonts/Font.cpp (right):

https://codereview.chromium.org/2807913002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/fonts/Font.cpp:162: DCHECK((runInfo.from ==
0) && (runInfo.to == run.length()));
Split this into two DCHECK_EQs

https://codereview.chromium.org/2807913002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/fonts/ScriptRunIteratorTest.cpp (right):

https://codereview.chromium.org/2807913002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/fonts/ScriptRunIteratorTest.cpp:90: DCHECK(ch
>= kMockCharMin && ch < kMockCharLimit);
Split this into two DCHECKs

https://codereview.chromium.org/2807913002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/fonts/mac/FontFamilyMatcherMac.mm
(right):

https://codereview.chromium.org/2807913002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/fonts/mac/FontFamilyMatcherMac.mm:60:
DCHECK(fontWeight >= 0 && fontWeight <= 8);
Split this into two DCHECKs.

https://codereview.chromium.org/2807913002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/fonts/shaping/ShapeCache.h (right):

https://codereview.chromium.org/2807913002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/fonts/shaping/ShapeCache.h:73: DCHECK(length
<= s_capacity);
Use DCHECK_LE

[Hwanseung Lee, 2017-04-11 15:21:06]

The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-11 15:21:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 15:34:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-11 15:34:08]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[Hwanseung Lee, 2017-04-11 16:16:39]

Patchset #3 (id:40001) has been deleted

[Hwanseung Lee, 2017-04-11 16:17:15]

The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-11 16:18:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 16:31:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-11 16:31:37]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Hwanseung Lee, 2017-04-11 16:37:56]

Patchset #3 (id:60001) has been deleted

[Hwanseung Lee, 2017-04-11 16:38:39]

The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-11 16:39:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 18:34:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-11 18:34:53]

Dry run: This issue passed the CQ dry run.

[Hwanseung Lee, 2017-04-11 22:25:09]

@tkent
PTAL, thank you.

https://codereview.chromium.org/2807913002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/fonts/Font.cpp (right):

https://codereview.chromium.org/2807913002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/fonts/Font.cpp:162: DCHECK((runInfo.from ==
0) && (runInfo.to == run.length()));
On 2017/04/09 23:13:23, tkent wrote:
> Split this into two DCHECK_EQs

Done.

https://codereview.chromium.org/2807913002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/fonts/ScriptRunIteratorTest.cpp (right):

https://codereview.chromium.org/2807913002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/fonts/ScriptRunIteratorTest.cpp:90: DCHECK(ch
>= kMockCharMin && ch < kMockCharLimit);
On 2017/04/09 23:13:23, tkent wrote:
> Split this into two DCHECKs

Done.

https://codereview.chromium.org/2807913002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/fonts/mac/FontFamilyMatcherMac.mm
(right):

https://codereview.chromium.org/2807913002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/fonts/mac/FontFamilyMatcherMac.mm:60:
DCHECK(fontWeight >= 0 && fontWeight <= 8);
On 2017/04/09 23:13:23, tkent wrote:
> Split this into two DCHECKs.

Done.

https://codereview.chromium.org/2807913002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/fonts/shaping/ShapeCache.h (right):

https://codereview.chromium.org/2807913002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/fonts/shaping/ShapeCache.h:73: DCHECK(length
<= s_capacity);
On 2017/04/09 23:13:23, tkent wrote:
> Use DCHECK_LE

it was cause of build fail. so i did not change.

[tkent, 2017-04-11 23:48:07]

lgtm

[Hwanseung Lee, 2017-04-11 23:57:09]

The CQ bit was checked by hs1217.lee@samsung.com

[Hwanseung Lee, 2017-04-11 23:57:10]

The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org
Link to the patchset: https://codereview.chromium.org/2807913002/#ps80001
(title: "rebase")

[commit-bot: I haz the power, 2017-04-11 23:58:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 00:10:25]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1491955029441010,
"parent_rev": "2ce547e8ae0c6a41876f95aec2465a0d1031ae52", "commit_rev":
"e5e496d06dc34dd313677ad3cd125d719d838830"}

[commit-bot: I haz the power, 2017-04-12 00:11:20]

Description was changed from

==========
Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/fonts

Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED
with DCHECK_op, CHECK_op, and NOTREACHED respectively in
third_party/WebKit/Source/platform/fonts

BUG=707657
==========

to

==========
Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/fonts

Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED
with DCHECK_op, CHECK_op, and NOTREACHED respectively in
third_party/WebKit/Source/platform/fonts

BUG=707657

Review-Url: https://codereview.chromium.org/2807913002
Cr-Commit-Position: refs/heads/master@{#463850}
Committed:
https://chromium.googlesource.com/chromium/src/+/e5e496d06dc34dd313677ad3cd12...
==========

[commit-bot: I haz the power, 2017-04-12 00:11:21]

Committed patchset #3 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/e5e496d06dc34dd313677ad3cd12...