Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: third_party/WebKit/Source/platform/fonts/FontPlatformData.cpp

Issue 2807913002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/fonts (Closed)
Patch Set: rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/fonts/FontPlatformData.cpp
diff --git a/third_party/WebKit/Source/platform/fonts/FontPlatformData.cpp b/third_party/WebKit/Source/platform/fonts/FontPlatformData.cpp
index 5adff1a441c340f95e35d624faf240c07e0de018..f2797155318a7bc0a0bbad0db9ed08cfb2563a99 100644
--- a/third_party/WebKit/Source/platform/fonts/FontPlatformData.cpp
+++ b/third_party/WebKit/Source/platform/fonts/FontPlatformData.cpp
@@ -223,7 +223,7 @@ SkFontID FontPlatformData::UniqueID() const {
}
String FontPlatformData::FontFamilyName() const {
- ASSERT(this->Typeface());
+ DCHECK(this->Typeface());
SkTypeface::LocalizedStrings* font_family_iterator =
this->Typeface()->createFamilyNameIterator();
SkTypeface::LocalizedString localized_string;
@@ -266,9 +266,9 @@ bool FontPlatformData::HasSpaceInLigaturesOrKerning(
return false;
hb_font_t* font = hb_face->GetScaledFont();
- ASSERT(font);
+ DCHECK(font);
hb_face_t* face = hb_font_get_face(font);
- ASSERT(face);
+ DCHECK(face);
hb_codepoint_t space;
// If the space glyph isn't present in the font then each space character

Powered by Google App Engine
This is Rietveld 408576698