third_party/WebKit/Source/platform/fonts/OrientationIteratorTest.cpp - Issue 2807913002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/fonts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/fonts/OrientationIteratorTest.cpp

Issue 2807913002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/fonts (Closed)

Patch Set: rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/fonts/OrientationIterator.cpp ('k') | third_party/WebKit/Source/platform/fonts/ScriptRunIterator.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/fonts/OrientationIteratorTest.cpp

diff --git a/third_party/WebKit/Source/platform/fonts/OrientationIteratorTest.cpp b/third_party/WebKit/Source/platform/fonts/OrientationIteratorTest.cpp

index d33b8bcbce01be5e99dfe30b3f67de52c67dba9f..68be8f9df3697ffd7ca6c1d180f2b414f4224463 100644

--- a/third_party/WebKit/Source/platform/fonts/OrientationIteratorTest.cpp

+++ b/third_party/WebKit/Source/platform/fonts/OrientationIteratorTest.cpp

@@ -66,7 +66,7 @@ TEST_F(OrientationIteratorTest, Empty) {

unsigned limit = 0;

OrientationIterator::RenderOrientation orientation =

OrientationIterator::kOrientationInvalid;

- ASSERT(!orientation_iterator.Consume(&limit, &orientation));

+ DCHECK(!orientation_iterator.Consume(&limit, &orientation));

ASSERT_EQ(limit, 0u);

ASSERT_EQ(orientation, OrientationIterator::kOrientationInvalid);

}