Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(862)

Unified Diff: third_party/WebKit/Source/platform/fonts/win/FontCacheSkiaWin.cpp

Issue 2807913002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/fonts (Closed)
Patch Set: rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/fonts/win/FontCacheSkiaWin.cpp
diff --git a/third_party/WebKit/Source/platform/fonts/win/FontCacheSkiaWin.cpp b/third_party/WebKit/Source/platform/fonts/win/FontCacheSkiaWin.cpp
index d230a9a517c01e0920685316067f2ebc782c89c9..be25c3a6b5e0b1be3c62a96bc6c1d20b0c0cd185 100644
--- a/third_party/WebKit/Source/platform/fonts/win/FontCacheSkiaWin.cpp
+++ b/third_party/WebKit/Source/platform/fonts/win/FontCacheSkiaWin.cpp
@@ -105,7 +105,7 @@ FontCache::FontCache() : purge_prevent_count_(0) {
font_manager_ = sk_ref_sp(static_font_manager_);
if (!font_manager_)
font_manager_ = SkFontMgr_New_DirectWrite();
- ASSERT(font_manager_.get());
+ DCHECK(font_manager_.get());
}
// Given the desired base font, this will create a SimpleFontData for a specific
@@ -336,7 +336,7 @@ std::unique_ptr<FontPlatformData> FontCache::CreateFontPlatformData(
const FontFaceCreationParams& creation_params,
float font_size,
AlternateFontName alternate_font_name) {
- ASSERT(creation_params.CreationType() == kCreateFontByFamily);
+ DCHECK_EQ(creation_params.CreationType(), kCreateFontByFamily);
CString name;
sk_sp<SkTypeface> tf =

Powered by Google App Engine
This is Rietveld 408576698