Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: third_party/WebKit/Source/platform/fonts/FontFallbackIterator.cpp

Issue 2807913002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/fonts (Closed)
Patch Set: rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/fonts/FontFallbackIterator.cpp
diff --git a/third_party/WebKit/Source/platform/fonts/FontFallbackIterator.cpp b/third_party/WebKit/Source/platform/fonts/FontFallbackIterator.cpp
index 8f9441bde08301c0544fb666d7eac67899f6fa65..782f704a2a6b98d926397dc8a498bbfe3790cc8c 100644
--- a/third_party/WebKit/Source/platform/fonts/FontFallbackIterator.cpp
+++ b/third_party/WebKit/Source/platform/fonts/FontFallbackIterator.cpp
@@ -123,7 +123,7 @@ PassRefPtr<FontDataForRangeSet> FontFallbackIterator::Next(
return AdoptRef(new FontDataForRangeSetFromCache(last_resort));
}
- ASSERT(fallback_stage_ == kFontGroupFonts ||
+ DCHECK(fallback_stage_ == kFontGroupFonts ||
fallback_stage_ == kSegmentedFace);
const FontData* font_data = font_fallback_list_->FontDataAt(
font_description_, current_font_data_index_);
@@ -163,7 +163,7 @@ PassRefPtr<FontDataForRangeSet> FontFallbackIterator::Next(
fallback_stage_ = kSegmentedFace;
}
- ASSERT(segmented_face_index_ < segmented->NumFaces());
+ DCHECK_LT(segmented_face_index_, segmented->NumFaces());
RefPtr<FontDataForRangeSet> current_segmented_face =
segmented->FaceAt(segmented_face_index_);
segmented_face_index_++;

Powered by Google App Engine
This is Rietveld 408576698