Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp

Issue 2807913002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/fonts (Closed)
Patch Set: rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp
diff --git a/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp b/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp
index df76993e98eebf805111f09007f9fd1ba3cc6e62..ea998002b1ab68f4ffef76fadddaca8144f90bb8 100644
--- a/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp
+++ b/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp
@@ -72,7 +72,7 @@ class HarfBuzzScopedPtr {
HarfBuzzScopedPtr(T* ptr, DestroyFunction destroy)
: ptr_(ptr), destroy_(destroy) {
- ASSERT(destroy_);
+ DCHECK(destroy_);
}
~HarfBuzzScopedPtr() {
if (ptr_)
@@ -259,7 +259,7 @@ bool HarfBuzzShaper::ExtractShapeResults(
}
// Here we need to put character positions.
- ASSERT(num_characters);
+ DCHECK(num_characters);
range_data->holes_queue.push_back(
HolesQueueItem(kHolesQueueRange, start_index, num_characters));
}
@@ -315,7 +315,7 @@ bool HarfBuzzShaper::CollectFallbackHintChars(
break;
UChar32 hint_char;
- RELEASE_ASSERT(it->start_index_ + it->num_characters_ <= text_length_);
+ CHECK_LE((it->start_index_ + it->num_characters_), text_length_);
UTF16TextIterator iterator(text_ + it->start_index_, it->num_characters_);
while (iterator.Consume(hint_char)) {
hint.push_back(hint_char);

Powered by Google App Engine
This is Rietveld 408576698