Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Unified Diff: third_party/WebKit/Source/platform/fonts/FontDataCache.cpp

Issue 2807913002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/fonts (Closed)
Patch Set: rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/fonts/FontDataCache.cpp
diff --git a/third_party/WebKit/Source/platform/fonts/FontDataCache.cpp b/third_party/WebKit/Source/platform/fonts/FontDataCache.cpp
index b0409f897e5431eb8bf890753c2855c79fa0018f..6a874904412fc3eb2c34a162c3059c73806d670f 100644
--- a/third_party/WebKit/Source/platform/fonts/FontDataCache.cpp
+++ b/third_party/WebKit/Source/platform/fonts/FontDataCache.cpp
@@ -77,7 +77,7 @@ PassRefPtr<SimpleFontData> FontDataCache::Get(
}
if (!result.Get()->value.second) {
- ASSERT(inactive_font_data_.Contains(result.Get()->value.first));
+ DCHECK(inactive_font_data_.Contains(result.Get()->value.first));
inactive_font_data_.erase(result.Get()->value.first);
}
@@ -98,14 +98,14 @@ bool FontDataCache::Contains(const FontPlatformData* font_platform_data) const {
}
void FontDataCache::Release(const SimpleFontData* font_data) {
- ASSERT(!font_data->IsCustomFont());
+ DCHECK(!font_data->IsCustomFont());
Cache::iterator it = cache_.Find(&(font_data->PlatformData()));
- ASSERT(it != cache_.end());
+ DCHECK_NE(it, cache_.end());
if (it == cache_.end())
return;
- ASSERT(it->value.second);
+ DCHECK(it->value.second);
if (!--it->value.second)
inactive_font_data_.insert(it->value.first);
}

Powered by Google App Engine
This is Rietveld 408576698