third_party/WebKit/Source/platform/fonts/opentype/OpenTypeVerticalData.cpp - Issue 2807913002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/fonts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/fonts/opentype/OpenTypeVerticalData.cpp

Issue 2807913002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/fonts (Closed)

Patch Set: rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/fonts/opentype/OpenTypeCapsSupportMPL.cpp ('k') | third_party/WebKit/Source/platform/fonts/shaping/CachingWordShapeIterator.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/fonts/opentype/OpenTypeVerticalData.cpp

diff --git a/third_party/WebKit/Source/platform/fonts/opentype/OpenTypeVerticalData.cpp b/third_party/WebKit/Source/platform/fonts/opentype/OpenTypeVerticalData.cpp

index 4fa03457897f5a8b02de19df9aeb93f36d98e585..53792557c39716615316053d988a75bba8e93ef5 100644

--- a/third_party/WebKit/Source/platform/fonts/opentype/OpenTypeVerticalData.cpp

+++ b/third_party/WebKit/Source/platform/fonts/opentype/OpenTypeVerticalData.cpp

@@ -245,7 +245,7 @@ void OpenTypeVerticalData::GetVerticalTranslationsForGlyphs(

size_t count,

float* out_xy_array) const {

size_t count_widths = advance_widths_.size();

- ASSERT(count_widths > 0);

+ DCHECK_GT(count_widths, 0u);

const FontMetrics& metrics = font->GetFontMetrics();

float size_per_unit = font->SizePerUnit();

float ascent = metrics.Ascent();