third_party/WebKit/Source/platform/fonts/SymbolsIteratorTest.cpp - Issue 2807913002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/fonts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/fonts/SymbolsIteratorTest.cpp

Issue 2807913002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/fonts (Closed)

Patch Set: rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/fonts/SymbolsIteratorTest.cpp

diff --git a/third_party/WebKit/Source/platform/fonts/SymbolsIteratorTest.cpp b/third_party/WebKit/Source/platform/fonts/SymbolsIteratorTest.cpp

index 3b72f1d0ccae3938b64ae718c9f8146891da2eb4..569d80d414f623f1939255ba21e0c8384ee4a571 100644

--- a/third_party/WebKit/Source/platform/fonts/SymbolsIteratorTest.cpp

+++ b/third_party/WebKit/Source/platform/fonts/SymbolsIteratorTest.cpp

@@ -67,7 +67,7 @@ TEST_F(SymbolsIteratorTest, Empty) {

SymbolsIterator symbols_iterator(empty.Characters16(), empty.length());

unsigned limit = 0;

FontFallbackPriority symbols_font = FontFallbackPriority::kInvalid;

- ASSERT(!symbols_iterator.Consume(&limit, &symbols_font));

+ DCHECK(!symbols_iterator.Consume(&limit, &symbols_font));

ASSERT_EQ(limit, 0u);

ASSERT_EQ(symbols_font, FontFallbackPriority::kInvalid);

}