third_party/WebKit/Source/platform/fonts/shaping/RunSegmenterTest.cpp - Issue 2807913002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/fonts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/fonts/shaping/RunSegmenterTest.cpp

Issue 2807913002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/fonts (Closed)

Patch Set: rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/fonts/shaping/RunSegmenter.cpp ('k') | third_party/WebKit/Source/platform/fonts/shaping/ShapeCache.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/fonts/shaping/RunSegmenterTest.cpp

diff --git a/third_party/WebKit/Source/platform/fonts/shaping/RunSegmenterTest.cpp b/third_party/WebKit/Source/platform/fonts/shaping/RunSegmenterTest.cpp

index 4150ec5645a5efff01bb22bdf9f70dc1c0b08020..6eff95ade13a1e94680cee88f13ccf9f7a8da21e 100644

--- a/third_party/WebKit/Source/platform/fonts/shaping/RunSegmenterTest.cpp

+++ b/third_party/WebKit/Source/platform/fonts/shaping/RunSegmenterTest.cpp

@@ -96,7 +96,7 @@ TEST_F(RunSegmenterTest, Empty) {

0, 0, USCRIPT_INVALID_CODE, OrientationIterator::kOrientationKeep};

RunSegmenter run_segmenter(empty.Characters16(), empty.length(),

FontOrientation::kVerticalMixed);

- ASSERT(!run_segmenter.Consume(&segmenter_range));

+ DCHECK(!run_segmenter.Consume(&segmenter_range));

ASSERT_EQ(segmenter_range.start, 0u);

ASSERT_EQ(segmenter_range.end, 0u);

ASSERT_EQ(segmenter_range.script, USCRIPT_INVALID_CODE);