third_party/WebKit/Source/platform/fonts/OrientationIterator.cpp - Issue 2807913002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/fonts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/fonts/OrientationIterator.cpp

Issue 2807913002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/fonts (Closed)

Patch Set: rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/fonts/OrientationIterator.cpp

diff --git a/third_party/WebKit/Source/platform/fonts/OrientationIterator.cpp b/third_party/WebKit/Source/platform/fonts/OrientationIterator.cpp

index 191ea41984ba9ed545943582e3c9e7e6a6404e1d..2786a6d22444868c0e7f7cad403ec33a21e5cb98 100644

--- a/third_party/WebKit/Source/platform/fonts/OrientationIterator.cpp

+++ b/third_party/WebKit/Source/platform/fonts/OrientationIterator.cpp

@@ -16,7 +16,7 @@ OrientationIterator::OrientationIterator(const UChar* buffer,

at_end_(buffer_size == 0) {

// There's not much point in segmenting by isUprightInVertical if the text

// orientation is not "mixed".

- ASSERT(run_orientation == FontOrientation::kVerticalMixed);

+ DCHECK_EQ(run_orientation, FontOrientation::kVerticalMixed);

}

bool OrientationIterator::Consume(unsigned* orientation_limit,