Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 2806863003: [Page Load Metrics] Structure PageLoadTiming. (Closed)

Created:
3 years, 8 months ago by lpy
Modified:
3 years, 8 months ago
CC:
cbentzel+watch_chromium.org, chromium-reviews, csharrison+watch_chromium.org, gavinp+prer_chromium.org, loading-reviews+metrics_chromium.org, speed-metrics-reviews_chromium.org, subresource-filter-reviews_chromium.org, tbansal+watch-data-reduction-proxy_chromium.org, tburkard+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Page Load Metrics] Structure PageLoadTiming. Add another 3 categories to PageLoadTiming to group different types of timing, which are DocumentTiming, ParseTiming and PaintTiming. DocumentTiming includes: * dom_content_loaded_event_start * load_event_start * first_layout ParseTiming includes: * parse_start * parse_stop * parse_blocked_on_script_load_duration * parse_blocked_on_script_load_from_document_write_duration * parse_blocked_on_script_execution_duration * parse_blocked_on_script_execution_from_document_write_duration PaintTiming includes: * first_paint * first_text_paint * first_image_paint * first_contentful_paint * first_meaningful_paint BUG=711351 Review-Url: https://codereview.chromium.org/2806863003 Cr-Commit-Position: refs/heads/master@{#464693} Committed: https://chromium.googlesource.com/chromium/src/+/e95b6b3993dedab3ee364fa591ad032ab243fa6a

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1007 lines, -731 lines) Patch
M chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.cc View 1 chunk +6 lines, -3 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/page_load_metrics/observers/amp_page_load_metrics_observer.cc View 1 chunk +17 lines, -14 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/amp_page_load_metrics_observer_unittest.cc View 2 chunks +12 lines, -10 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/android_page_load_metrics_observer.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc View 1 12 chunks +108 lines, -93 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc View 1 24 chunks +48 lines, -39 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/css_scanning_page_load_metrics_observer.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.cc View 8 chunks +33 lines, -28 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer_unittest.cc View 3 chunks +35 lines, -33 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/delay_navigation_page_load_metrics_observer_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.cc View 1 5 chunks +43 lines, -36 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer_unittest.cc View 1 5 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.cc View 1 2 4 chunks +35 lines, -26 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer_unittest.cc View 1 19 chunks +66 lines, -53 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/media_page_load_metrics_observer_unittest.cc View 1 chunk +6 lines, -5 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/no_state_prefetch_page_load_metrics_observer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/omnibox_suggestion_used_page_load_metrics_observer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc View 1 chunk +49 lines, -37 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/prerender_page_load_metrics_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/page_load_metrics/observers/previews_page_load_metrics_observer.cc View 1 chunk +13 lines, -13 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/previews_page_load_metrics_observer_unittest.cc View 2 chunks +11 lines, -10 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/protocol_page_load_metrics_observer.cc View 10 chunks +27 lines, -21 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/protocol_page_load_metrics_observer_unittest.cc View 1 chunk +9 lines, -6 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/resource_prefetch_predictor_page_load_metrics_observer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/resource_prefetch_predictor_page_load_metrics_observer_unittest.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer.cc View 1 4 chunks +23 lines, -19 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer_unittest.cc View 1 9 chunks +28 lines, -17 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer.cc View 1 6 chunks +29 lines, -21 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer_unittest.cc View 1 4 chunks +28 lines, -17 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/tab_restore_page_load_metrics_observer_unittest.cc View 1 chunk +6 lines, -5 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.cc View 1 chunk +19 lines, -14 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer_unittest.cc View 3 chunks +10 lines, -6 lines 0 comments Download
M chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/page_load_metrics/page_load_tracker.cc View 1 3 chunks +90 lines, -60 lines 0 comments Download
M chrome/browser/prerender/prerender_browsertest.cc View 7 chunks +14 lines, -7 lines 0 comments Download
M chrome/common/page_load_metrics/page_load_metrics_messages.h View 2 chunks +20 lines, -8 lines 0 comments Download
M chrome/common/page_load_metrics/page_load_timing.h View 1 3 chunks +80 lines, -42 lines 0 comments Download
M chrome/common/page_load_metrics/page_load_timing.cc View 1 2 chunks +68 lines, -28 lines 0 comments Download
M chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc View 1 1 chunk +26 lines, -18 lines 0 comments Download
M chrome/renderer/page_load_metrics/metrics_render_frame_observer_unittest.cc View 5 chunks +10 lines, -10 lines 0 comments Download
M chrome/renderer/page_load_metrics/page_timing_metrics_sender_unittest.cc View 5 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 51 (36 generated)
lpy
PTAL.
3 years, 8 months ago (2017-04-10 21:44:12 UTC) #20
lpy
On 2017/04/10 21:44:12, lpy wrote: > PTAL. gentle ping for review.
3 years, 8 months ago (2017-04-11 18:29:51 UTC) #21
Bryan McQuade
LGTM. Thanks so much for making this change! This has been something I've wanted us ...
3 years, 8 months ago (2017-04-12 01:37:20 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2806863003/60001
3 years, 8 months ago (2017-04-12 02:50:51 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/408816)
3 years, 8 months ago (2017-04-12 03:00:09 UTC) #26
lpy
+pasko@ for prerender/ PTAL.
3 years, 8 months ago (2017-04-12 18:51:01 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2806863003/80001
3 years, 8 months ago (2017-04-12 19:46:22 UTC) #35
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/409576)
3 years, 8 months ago (2017-04-12 20:01:11 UTC) #37
pasko
chrome/browser/prerender/ lgtm
3 years, 8 months ago (2017-04-13 12:37:42 UTC) #38
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2806863003/80001
3 years, 8 months ago (2017-04-13 16:58:59 UTC) #40
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/410602)
3 years, 8 months ago (2017-04-13 17:08:10 UTC) #42
lpy
+mkwst@, ptal at page_load_metrics_messages
3 years, 8 months ago (2017-04-13 17:11:35 UTC) #44
Mike West
IPC LGTM.
3 years, 8 months ago (2017-04-14 06:01:44 UTC) #46
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2806863003/80001
3 years, 8 months ago (2017-04-14 06:02:34 UTC) #48
commit-bot: I haz the power
3 years, 8 months ago (2017-04-14 06:48:33 UTC) #51
Message was sent while issue was closed.
Committed patchset #3 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/e95b6b3993dedab3ee364fa591ad...

Powered by Google App Engine
This is Rietveld 408576698