Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2984)

Unified Diff: chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.cc

Issue 2806863003: [Page Load Metrics] Structure PageLoadTiming. (Closed)
Patch Set: rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.cc
diff --git a/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.cc
index aaa848f9158aa24df7908a099843a51eabd21473..48a9bc06c278f7d840147c3c57088d921fee846e 100644
--- a/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.cc
+++ b/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.cc
@@ -312,11 +312,14 @@ void AbortsPageLoadMetricsObserver::OnComplete(
if (timing.IsEmpty())
return;
- if (timing.parse_start && abort_info.time_to_abort >= timing.parse_start &&
- (!timing.parse_stop || timing.parse_stop >= abort_info.time_to_abort)) {
+ if (timing.parse_timing.parse_start &&
+ abort_info.time_to_abort >= timing.parse_timing.parse_start &&
+ (!timing.parse_timing.parse_stop ||
+ timing.parse_timing.parse_stop >= abort_info.time_to_abort)) {
RecordAbortDuringParse(abort_info);
}
- if (!timing.first_paint || timing.first_paint >= abort_info.time_to_abort) {
+ if (!timing.paint_timing.first_paint ||
+ timing.paint_timing.first_paint >= abort_info.time_to_abort) {
RecordAbortAfterCommitBeforePaint(abort_info);
}
}
« no previous file with comments | « no previous file | chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698