Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3945)

Unified Diff: chrome/renderer/page_load_metrics/metrics_render_frame_observer_unittest.cc

Issue 2806863003: [Page Load Metrics] Structure PageLoadTiming. (Closed)
Patch Set: rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/page_load_metrics/metrics_render_frame_observer_unittest.cc
diff --git a/chrome/renderer/page_load_metrics/metrics_render_frame_observer_unittest.cc b/chrome/renderer/page_load_metrics/metrics_render_frame_observer_unittest.cc
index 6142b1d2ff2bf799517a5b5e853a19bf5039b458..453f15b3740b6264a7220cdc420d5767c5e99eaf 100644
--- a/chrome/renderer/page_load_metrics/metrics_render_frame_observer_unittest.cc
+++ b/chrome/renderer/page_load_metrics/metrics_render_frame_observer_unittest.cc
@@ -102,7 +102,7 @@ TEST_F(MetricsRenderFrameObserverTest, SingleMetric) {
observer.DidCommitProvisionalLoad(true, false);
mock_timer->Fire();
- timing.first_layout = first_layout;
+ timing.document_timing.first_layout = first_layout;
observer.ExpectPageLoadTiming(timing);
observer.DidChangePerformanceTiming();
@@ -125,8 +125,8 @@ TEST_F(MetricsRenderFrameObserverTest, MultipleMetrics) {
observer.DidCommitProvisionalLoad(true, false);
mock_timer->Fire();
- timing.first_layout = first_layout;
- timing.dom_content_loaded_event_start = dom_event;
+ timing.document_timing.first_layout = first_layout;
+ timing.document_timing.dom_content_loaded_event_start = dom_event;
observer.ExpectPageLoadTiming(timing);
observer.DidChangePerformanceTiming();
@@ -137,7 +137,7 @@ TEST_F(MetricsRenderFrameObserverTest, MultipleMetrics) {
// part of the test.
observer.VerifyExpectedTimings();
- timing.load_event_start = load_event;
+ timing.document_timing.load_event_start = load_event;
observer.ExpectPageLoadTiming(timing);
observer.DidChangePerformanceTiming();
@@ -171,9 +171,9 @@ TEST_F(MetricsRenderFrameObserverTest, MultipleNavigations) {
observer.DidCommitProvisionalLoad(true, false);
mock_timer->Fire();
- timing.first_layout = first_layout;
- timing.dom_content_loaded_event_start = dom_event;
- timing.load_event_start = load_event;
+ timing.document_timing.first_layout = first_layout;
+ timing.document_timing.dom_content_loaded_event_start = dom_event;
+ timing.document_timing.load_event_start = load_event;
observer.ExpectPageLoadTiming(timing);
observer.DidChangePerformanceTiming();
mock_timer->Fire();
@@ -197,9 +197,9 @@ TEST_F(MetricsRenderFrameObserverTest, MultipleNavigations) {
observer.DidCommitProvisionalLoad(true, false);
mock_timer2->Fire();
- timing_2.first_layout = first_layout_2;
- timing_2.dom_content_loaded_event_start = dom_event_2;
- timing_2.load_event_start = load_event_2;
+ timing_2.document_timing.first_layout = first_layout_2;
+ timing_2.document_timing.dom_content_loaded_event_start = dom_event_2;
+ timing_2.document_timing.load_event_start = load_event_2;
observer.ExpectPageLoadTiming(timing_2);
observer.DidChangePerformanceTiming();

Powered by Google App Engine
This is Rietveld 408576698