chrome/browser/page_load_metrics/observers/resource_prefetch_predictor_page_load_metrics_observer_unittest.cc - Issue 2806863003: [Page Load Metrics] Structure PageLoadTiming.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/resource_prefetch_predictor_page_load_metrics_observer_unittest.cc

Issue 2806863003: [Page Load Metrics] Structure PageLoadTiming. (Closed)

Patch Set: rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/page_load_metrics/observers/resource_prefetch_predictor_page_load_metrics_observer.cc ('k') | chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/resource_prefetch_predictor_page_load_metrics_observer_unittest.cc

diff --git a/chrome/browser/page_load_metrics/observers/resource_prefetch_predictor_page_load_metrics_observer_unittest.cc b/chrome/browser/page_load_metrics/observers/resource_prefetch_predictor_page_load_metrics_observer_unittest.cc

index bac976786bed6ff7aac17943bca331da9ccc425d..c511043181032e8acbb8386015e9eaaa4f3a03c6 100644

--- a/chrome/browser/page_load_metrics/observers/resource_prefetch_predictor_page_load_metrics_observer_unittest.cc

+++ b/chrome/browser/page_load_metrics/observers/resource_prefetch_predictor_page_load_metrics_observer_unittest.cc

@@ -37,9 +37,11 @@ class ResourcePrefetchPredictorPageLoadMetricsObserverTest

base::MakeUnique<testing::StrictMock<MockResourcePrefetchPredictor>>(

config, profile());

timing_.navigation_start = base::Time::FromDoubleT(1);

- timing_.first_paint = base::TimeDelta::FromSeconds(2);

- timing_.first_contentful_paint = base::TimeDelta::FromSeconds(3);

- timing_.first_meaningful_paint = base::TimeDelta::FromSeconds(4);

+ timing_.paint_timing.first_paint = base::TimeDelta::FromSeconds(2);

+ timing_.paint_timing.first_contentful_paint =

+ base::TimeDelta::FromSeconds(3);

+ timing_.paint_timing.first_meaningful_paint =

+ base::TimeDelta::FromSeconds(4);

PopulateRequiredTimingFields(&timing_);

}