chrome/browser/page_load_metrics/observers/css_scanning_page_load_metrics_observer.cc - Issue 2806863003: [Page Load Metrics] Structure PageLoadTiming.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/css_scanning_page_load_metrics_observer.cc

Issue 2806863003: [Page Load Metrics] Structure PageLoadTiming. (Closed)

Patch Set: rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc ('k') | chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/css_scanning_page_load_metrics_observer.cc

diff --git a/chrome/browser/page_load_metrics/observers/css_scanning_page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/css_scanning_page_load_metrics_observer.cc

index 61dbfbf33cde92d741bf2a62a2dec1b9e9748964..8dc995cf264d5796c49c3dbf4c7d2c41079c6b79 100644

--- a/chrome/browser/page_load_metrics/observers/css_scanning_page_load_metrics_observer.cc

+++ b/chrome/browser/page_load_metrics/observers/css_scanning_page_load_metrics_observer.cc

@@ -44,7 +44,8 @@ void CssScanningMetricsObserver::OnFirstContentfulPaint(

PAGE_LOAD_HISTOGRAM(

"PageLoad.Clients.CssScanner.PaintTiming."

"ParseStartToFirstContentfulPaint",

- timing.first_contentful_paint.value() - timing.parse_start.value());

+ timing.paint_timing.first_contentful_paint.value() -

+ timing.parse_timing.parse_start.value());

}

void CssScanningMetricsObserver::OnFirstMeaningfulPaint(

@@ -56,5 +57,6 @@ void CssScanningMetricsObserver::OnFirstMeaningfulPaint(

PAGE_LOAD_HISTOGRAM(

"PageLoad.Clients.CssScanner.Experimental.PaintTiming."

"ParseStartToFirstMeaningfulPaint",

- timing.first_meaningful_paint.value() - timing.parse_start.value());

+ timing.paint_timing.first_meaningful_paint.value() -

+ timing.parse_timing.parse_start.value());

}