chrome/browser/page_load_metrics/observers/prerender_page_load_metrics_observer.cc - Issue 2806863003: [Page Load Metrics] Structure PageLoadTiming.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/prerender_page_load_metrics_observer.cc

Issue 2806863003: [Page Load Metrics] Structure PageLoadTiming. (Closed)

Patch Set: rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc ('k') | chrome/browser/page_load_metrics/observers/previews_page_load_metrics_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/prerender_page_load_metrics_observer.cc

diff --git a/chrome/browser/page_load_metrics/observers/prerender_page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/prerender_page_load_metrics_observer.cc

index f2426ed6eba9a97f478092c2e2d307ece1b72fee..99f18ab83527119c2343436b15c11f1c8bb16596 100644

--- a/chrome/browser/page_load_metrics/observers/prerender_page_load_metrics_observer.cc

+++ b/chrome/browser/page_load_metrics/observers/prerender_page_load_metrics_observer.cc

@@ -67,7 +67,7 @@ void PrerenderPageLoadMetricsObserver::OnFirstContentfulPaint(

DCHECK(!start_ticks_.is_null());

prerender_manager_->RecordPrerenderFirstContentfulPaint(

extra_info.start_url, web_contents_, is_no_store_, was_hidden_,

- start_ticks_ + *timing.first_contentful_paint);

+ start_ticks_ + *timing.paint_timing.first_contentful_paint);

}

page_load_metrics::PageLoadMetricsObserver::ObservePolicy