Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Unified Diff: chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.cc

Issue 2806863003: [Page Load Metrics] Structure PageLoadTiming. (Closed)
Patch Set: rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.cc
diff --git a/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.cc
index dd8aaf7efede949e515e3d3883c90526a37cc3a1..038c9d6a628eeeb8ff27adad35555e23b0478c09 100644
--- a/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.cc
+++ b/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.cc
@@ -149,26 +149,31 @@ void UkmPageLoadMetricsObserver::RecordTimingMetrics(
ukm::UkmService* ukm_service = g_browser_process->ukm_service();
std::unique_ptr<ukm::UkmEntryBuilder> builder =
ukm_service->GetEntryBuilder(source_id_, internal::kUkmPageLoadEventName);
- if (timing.parse_start) {
- builder->AddMetric(internal::kUkmParseStartName,
- timing.parse_start.value().InMilliseconds());
+ if (timing.parse_timing.parse_start) {
+ builder->AddMetric(
+ internal::kUkmParseStartName,
+ timing.parse_timing.parse_start.value().InMilliseconds());
}
- if (timing.dom_content_loaded_event_start) {
+ if (timing.document_timing.dom_content_loaded_event_start) {
builder->AddMetric(
internal::kUkmDomContentLoadedName,
- timing.dom_content_loaded_event_start.value().InMilliseconds());
+ timing.document_timing.dom_content_loaded_event_start.value()
+ .InMilliseconds());
}
- if (timing.load_event_start) {
- builder->AddMetric(internal::kUkmLoadEventName,
- timing.load_event_start.value().InMilliseconds());
+ if (timing.document_timing.load_event_start) {
+ builder->AddMetric(
+ internal::kUkmLoadEventName,
+ timing.document_timing.load_event_start.value().InMilliseconds());
}
- if (timing.first_contentful_paint) {
- builder->AddMetric(internal::kUkmFirstContentfulPaintName,
- timing.first_contentful_paint.value().InMilliseconds());
+ if (timing.paint_timing.first_contentful_paint) {
+ builder->AddMetric(
+ internal::kUkmFirstContentfulPaintName,
+ timing.paint_timing.first_contentful_paint.value().InMilliseconds());
}
- if (timing.first_meaningful_paint) {
- builder->AddMetric(internal::kUkmFirstMeaningfulPaintName,
- timing.first_meaningful_paint.value().InMilliseconds());
+ if (timing.paint_timing.first_meaningful_paint) {
+ builder->AddMetric(
+ internal::kUkmFirstMeaningfulPaintName,
+ timing.paint_timing.first_meaningful_paint.value().InMilliseconds());
}
}

Powered by Google App Engine
This is Rietveld 408576698