chrome/browser/page_load_metrics/observers/tab_restore_page_load_metrics_observer_unittest.cc - Issue 2806863003: [Page Load Metrics] Structure PageLoadTiming.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/tab_restore_page_load_metrics_observer_unittest.cc

Issue 2806863003: [Page Load Metrics] Structure PageLoadTiming. (Closed)

Patch Set: rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer_unittest.cc ('k') | chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/tab_restore_page_load_metrics_observer_unittest.cc

diff --git a/chrome/browser/page_load_metrics/observers/tab_restore_page_load_metrics_observer_unittest.cc b/chrome/browser/page_load_metrics/observers/tab_restore_page_load_metrics_observer_unittest.cc

index 8ee9a0ad07ce949b84168b5615ebab2e3c6dde4c..6b0963e26989d1c355413932a17199f492ba6f6a 100644

--- a/chrome/browser/page_load_metrics/observers/tab_restore_page_load_metrics_observer_unittest.cc

+++ b/chrome/browser/page_load_metrics/observers/tab_restore_page_load_metrics_observer_unittest.cc

@@ -51,11 +51,12 @@ class TabRestorePageLoadMetricsObserverTest

// Reset to the default testing state. Does not reset histogram state.

timing_.navigation_start = base::Time::FromDoubleT(1);

timing_.response_start = base::TimeDelta::FromSeconds(2);

- timing_.parse_start = base::TimeDelta::FromSeconds(3);

- timing_.first_contentful_paint = base::TimeDelta::FromSeconds(4);

- timing_.first_image_paint = base::TimeDelta::FromSeconds(5);

- timing_.first_text_paint = base::TimeDelta::FromSeconds(6);

- timing_.load_event_start = base::TimeDelta::FromSeconds(7);

+ timing_.parse_timing.parse_start = base::TimeDelta::FromSeconds(3);

+ timing_.paint_timing.first_contentful_paint =

+ base::TimeDelta::FromSeconds(4);

+ timing_.paint_timing.first_image_paint = base::TimeDelta::FromSeconds(5);

+ timing_.paint_timing.first_text_paint = base::TimeDelta::FromSeconds(6);

+ timing_.document_timing.load_event_start = base::TimeDelta::FromSeconds(7);

PopulateRequiredTimingFields(&timing_);

network_bytes_ = 0;