chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer_unittest.cc - Issue 2806863003: [Page Load Metrics] Structure PageLoadTiming.

Unified Diff: chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer_unittest.cc

Issue 2806863003: [Page Load Metrics] Structure PageLoadTiming. (Closed)

Patch Set: rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.cc ('k') | chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer_unittest.cc

diff --git a/chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer_unittest.cc b/chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer_unittest.cc

index d4b7b8293dd1e9e42bab7192bb0da6dc1e462c8f..7b8dad7fce9f4fc7de8ea7894fbea6e47eae148b 100644

--- a/chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer_unittest.cc

+++ b/chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer_unittest.cc

@@ -36,8 +36,8 @@ TEST_F(DocumentWritePageLoadMetricsObserverTest, PossiblePreload) {

base::TimeDelta contentful_paint = base::TimeDelta::FromMilliseconds(1);

page_load_metrics::PageLoadTiming timing;

timing.navigation_start = base::Time::FromDoubleT(1);

- timing.first_contentful_paint = contentful_paint;

- timing.parse_start = base::TimeDelta::FromMilliseconds(1);

+ timing.paint_timing.first_contentful_paint = contentful_paint;

+ timing.parse_timing.parse_start = base::TimeDelta::FromMilliseconds(1);

PopulateRequiredTimingFields(&timing);

page_load_metrics::PageLoadMetadata metadata;

@@ -65,7 +65,7 @@ TEST_F(DocumentWritePageLoadMetricsObserverTest, NoPossiblePreload) {

base::TimeDelta contentful_paint = base::TimeDelta::FromMilliseconds(1);

page_load_metrics::PageLoadTiming timing;

timing.navigation_start = base::Time::FromDoubleT(1);

- timing.first_contentful_paint = contentful_paint;

+ timing.paint_timing.first_contentful_paint = contentful_paint;

PopulateRequiredTimingFields(&timing);

page_load_metrics::PageLoadMetadata metadata;

@@ -79,8 +79,8 @@ TEST_F(DocumentWritePageLoadMetricsObserverTest, PossibleBlock) {

base::TimeDelta contentful_paint = base::TimeDelta::FromMilliseconds(1);

page_load_metrics::PageLoadTiming timing;

timing.navigation_start = base::Time::FromDoubleT(1);

- timing.first_contentful_paint = contentful_paint;

- timing.parse_start = base::TimeDelta::FromMilliseconds(1);

+ timing.paint_timing.first_contentful_paint = contentful_paint;

+ timing.parse_timing.parse_start = base::TimeDelta::FromMilliseconds(1);

PopulateRequiredTimingFields(&timing);

page_load_metrics::PageLoadMetadata metadata;

@@ -110,8 +110,8 @@ TEST_F(DocumentWritePageLoadMetricsObserverTest, PossibleBlockReload) {

base::TimeDelta contentful_paint = base::TimeDelta::FromMilliseconds(1);

page_load_metrics::PageLoadTiming timing;

timing.navigation_start = base::Time::FromDoubleT(1);

- timing.first_contentful_paint = contentful_paint;

- timing.parse_start = base::TimeDelta::FromMilliseconds(1);

+ timing.paint_timing.first_contentful_paint = contentful_paint;

+ timing.parse_timing.parse_start = base::TimeDelta::FromMilliseconds(1);

PopulateRequiredTimingFields(&timing);

page_load_metrics::PageLoadMetadata metadata;

@@ -145,7 +145,7 @@ TEST_F(DocumentWritePageLoadMetricsObserverTest, NoPossibleBlock) {

base::TimeDelta contentful_paint = base::TimeDelta::FromMilliseconds(1);

page_load_metrics::PageLoadTiming timing;

timing.navigation_start = base::Time::FromDoubleT(1);

- timing.first_contentful_paint = contentful_paint;

+ timing.paint_timing.first_contentful_paint = contentful_paint;

PopulateRequiredTimingFields(&timing);

page_load_metrics::PageLoadMetadata metadata;