chrome/browser/prerender/prerender_browsertest.cc - Issue 2806863003: [Page Load Metrics] Structure PageLoadTiming.

Unified Diff: chrome/browser/prerender/prerender_browsertest.cc

Issue 2806863003: [Page Load Metrics] Structure PageLoadTiming. (Closed)

Patch Set: rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « chrome/browser/page_load_metrics/page_load_tracker.cc ('k') | chrome/common/page_load_metrics/page_load_metrics_messages.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/prerender/prerender_browsertest.cc

diff --git a/chrome/browser/prerender/prerender_browsertest.cc b/chrome/browser/prerender/prerender_browsertest.cc

index 22e9b036545db0ec7b7e7eec594f89866049b808..e12a5733ba09da50f51f980c58f199040592f426 100644

--- a/chrome/browser/prerender/prerender_browsertest.cc

+++ b/chrome/browser/prerender/prerender_browsertest.cc

@@ -3306,7 +3306,8 @@ IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest, FirstContentfulPaintTimingSimple) {

page_load_metrics::PageLoadTiming timing;

timing.navigation_start = base::Time::FromDoubleT(1); // Non-null time.

- timing.first_contentful_paint = base::TimeDelta::FromMilliseconds(2654);

+ timing.paint_timing.first_contentful_paint =

+ base::TimeDelta::FromMilliseconds(2654);

page_load_metrics::PageLoadMetricsObserverTestHarness::

PopulateRequiredTimingFields(&timing);

observer.OnFirstContentfulPaint(timing, GenericPageLoadExtraInfo(dest_url()));

@@ -3347,7 +3348,8 @@ IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest, FirstContentfulPaintTimingReuse) {

page_load_metrics::PageLoadTiming timing;

timing.navigation_start = base::Time::FromDoubleT(1); // Non-null time.

- timing.first_contentful_paint = base::TimeDelta::FromMilliseconds(2361);

+ timing.paint_timing.first_contentful_paint =

+ base::TimeDelta::FromMilliseconds(2361);

page_load_metrics::PageLoadMetricsObserverTestHarness::

PopulateRequiredTimingFields(&timing);

observer.OnFirstContentfulPaint(timing, GenericPageLoadExtraInfo(dest_url()));

@@ -3387,7 +3389,8 @@ IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest,

page_load_metrics::PageLoadTiming timing;

timing.navigation_start = base::Time::FromDoubleT(1); // Non-null time.

- timing.first_contentful_paint = base::TimeDelta::FromMilliseconds(2361);

+ timing.paint_timing.first_contentful_paint =

+ base::TimeDelta::FromMilliseconds(2361);

page_load_metrics::PageLoadMetricsObserverTestHarness::

PopulateRequiredTimingFields(&timing);

observer.OnFirstContentfulPaint(timing, GenericPageLoadExtraInfo(dest_url()));

@@ -3430,7 +3433,8 @@ IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest,

page_load_metrics::PageLoadTiming timing;

timing.navigation_start = base::Time::FromDoubleT(1); // Non-null time.

- timing.first_contentful_paint = base::TimeDelta::FromMilliseconds(2362);

+ timing.paint_timing.first_contentful_paint =

+ base::TimeDelta::FromMilliseconds(2362);

page_load_metrics::PageLoadMetricsObserverTestHarness::

PopulateRequiredTimingFields(&timing);

observer.OnFirstContentfulPaint(timing, GenericPageLoadExtraInfo(dest_url()));

@@ -3479,7 +3483,8 @@ IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest,

page_load_metrics::PageLoadTiming timing;

timing.navigation_start = base::Time::FromDoubleT(1); // Non-null time.

// The FCP time should end up on the edge of the bucket.

- timing.first_contentful_paint = base::TimeDelta::FromMilliseconds(2654);

+ timing.paint_timing.first_contentful_paint =

+ base::TimeDelta::FromMilliseconds(2654);

page_load_metrics::PageLoadMetricsObserverTestHarness::

PopulateRequiredTimingFields(&timing);

observer.OnFirstContentfulPaint(timing, GenericPageLoadExtraInfo(dest_url()));

@@ -3509,7 +3514,8 @@ IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest, FirstContentfulPaintHidden) {

page_load_metrics::PageLoadTiming timing;

timing.navigation_start = base::Time::FromDoubleT(1); // Non-null time.

- timing.first_contentful_paint = base::TimeDelta::FromMilliseconds(2654);

+ timing.paint_timing.first_contentful_paint =

+ base::TimeDelta::FromMilliseconds(2654);

page_load_metrics::PageLoadMetricsObserverTestHarness::

PopulateRequiredTimingFields(&timing);

observer.OnFirstContentfulPaint(timing, GenericPageLoadExtraInfo(dest_url()));

@@ -3554,7 +3560,8 @@ IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest,

page_load_metrics::PageLoadTiming timing;

timing.navigation_start = base::Time::FromDoubleT(1); // Non-null time.

- timing.first_contentful_paint = base::TimeDelta::FromMilliseconds(2362);

+ timing.paint_timing.first_contentful_paint =

+ base::TimeDelta::FromMilliseconds(2362);

page_load_metrics::PageLoadMetricsObserverTestHarness::

PopulateRequiredTimingFields(&timing);

observer.OnFirstContentfulPaint(timing, GenericPageLoadExtraInfo(dest_url()));