chrome/browser/page_load_metrics/observers/omnibox_suggestion_used_page_load_metrics_observer.cc - Issue 2806863003: [Page Load Metrics] Structure PageLoadTiming.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/omnibox_suggestion_used_page_load_metrics_observer.cc

Issue 2806863003: [Page Load Metrics] Structure PageLoadTiming. (Closed)

Patch Set: rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/page_load_metrics/observers/no_state_prefetch_page_load_metrics_observer.cc ('k') | chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/omnibox_suggestion_used_page_load_metrics_observer.cc

diff --git a/chrome/browser/page_load_metrics/observers/omnibox_suggestion_used_page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/omnibox_suggestion_used_page_load_metrics_observer.cc

index 58d13f4c1da534fb4141f47e108b1b2bf1e7208f..df91dc07d33567fbe95c717f87224b540d0fac05 100644

--- a/chrome/browser/page_load_metrics/observers/omnibox_suggestion_used_page_load_metrics_observer.cc

+++ b/chrome/browser/page_load_metrics/observers/omnibox_suggestion_used_page_load_metrics_observer.cc

@@ -63,7 +63,7 @@ OmniboxSuggestionUsedMetricsObserver::OnCommit(

void OmniboxSuggestionUsedMetricsObserver::OnFirstContentfulPaint(

const page_load_metrics::PageLoadTiming& timing,

const page_load_metrics::PageLoadExtraInfo& info) {

- base::TimeDelta fcp = timing.first_contentful_paint.value();

+ base::TimeDelta fcp = timing.paint_timing.first_contentful_paint.value();

if (info.started_in_foreground) {

if (ui::PageTransitionCoreTypeIs(transition_type_,

@@ -98,7 +98,7 @@ void OmniboxSuggestionUsedMetricsObserver::OnFirstContentfulPaint(

void OmniboxSuggestionUsedMetricsObserver::OnFirstMeaningfulPaint(

const page_load_metrics::PageLoadTiming& timing,

const page_load_metrics::PageLoadExtraInfo& info) {

- base::TimeDelta fmp = timing.first_meaningful_paint.value();

+ base::TimeDelta fmp = timing.paint_timing.first_meaningful_paint.value();

if (info.started_in_foreground) {

if (ui::PageTransitionCoreTypeIs(transition_type_,