Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2803853006: WebView: prefer ContentUrlConstants over literals (Closed)

Created:
3 years, 8 months ago by Nate Fischer
Modified:
3 years, 8 months ago
Reviewers:
boliu
CC:
agrieve+watch_chromium.org, android-webview-reviews_chromium.org, chromium-reviews, kalyank, sadrul
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

WebView: prefer ContentUrlConstants over literals No logic change. This CL swaps "about:*" literals for the correct value in ContentUrlConstants. Review-Url: https://codereview.chromium.org/2803853006 Cr-Commit-Position: refs/heads/master@{#462749} Committed: https://chromium.googlesource.com/chromium/src/+/0ac6602eb8a9152a55bf395bac1157ceb06fde71

Patch Set 1 #

Total comments: 2

Patch Set 2 : Revert changes to system webview shell #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -45 lines) Patch
M android_webview/java/src/org/chromium/android_webview/AwContents.java View 2 chunks +3 lines, -2 lines 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java View 2 chunks +2 lines, -1 line 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwWebContentsObserver.java View 2 chunks +2 lines, -1 line 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientVisitedHistoryTest.java View 2 chunks +2 lines, -1 line 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwContentsGarbageCollectionTest.java View 6 chunks +10 lines, -5 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwContentsRenderTest.java View 3 chunks +5 lines, -2 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java View 7 chunks +12 lines, -10 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwLegacyQuirksTest.java View 2 chunks +2 lines, -1 line 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java View 2 chunks +3 lines, -1 line 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/ClientOnPageFinishedTest.java View 3 chunks +3 lines, -2 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/ClientOnPageStartedTest.java View 3 chunks +3 lines, -2 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/ClientOnReceivedError2Test.java View 3 chunks +4 lines, -3 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/GeolocationTest.java View 9 chunks +17 lines, -8 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/LoadDataWithBaseUrlTest.java View 4 chunks +5 lines, -4 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/crash/VisualStateCallbackTest.java View 2 chunks +2 lines, -1 line 0 comments Download
M android_webview/test/shell/src/org/chromium/android_webview/shell/AwShellActivity.java View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 18 (12 generated)
Nate Fischer
PTAL
3 years, 8 months ago (2017-04-07 02:17:39 UTC) #4
boliu
https://codereview.chromium.org/2803853006/diff/1/android_webview/tools/system_webview_shell/apk/src/org/chromium/webview_shell/TelemetryActivity.java File android_webview/tools/system_webview_shell/apk/src/org/chromium/webview_shell/TelemetryActivity.java (right): https://codereview.chromium.org/2803853006/diff/1/android_webview/tools/system_webview_shell/apk/src/org/chromium/webview_shell/TelemetryActivity.java#newcode15 android_webview/tools/system_webview_shell/apk/src/org/chromium/webview_shell/TelemetryActivity.java:15: import org.chromium.content_public.common.ContentUrlConstants; I don't think we want to pull ...
3 years, 8 months ago (2017-04-07 02:32:32 UTC) #5
Nate Fischer
https://codereview.chromium.org/2803853006/diff/1/android_webview/tools/system_webview_shell/apk/src/org/chromium/webview_shell/TelemetryActivity.java File android_webview/tools/system_webview_shell/apk/src/org/chromium/webview_shell/TelemetryActivity.java (right): https://codereview.chromium.org/2803853006/diff/1/android_webview/tools/system_webview_shell/apk/src/org/chromium/webview_shell/TelemetryActivity.java#newcode15 android_webview/tools/system_webview_shell/apk/src/org/chromium/webview_shell/TelemetryActivity.java:15: import org.chromium.content_public.common.ContentUrlConstants; Ack. Reverted changes to WebView shell
3 years, 8 months ago (2017-04-07 02:47:20 UTC) #9
boliu
lgtm
3 years, 8 months ago (2017-04-07 02:48:36 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2803853006/20001
3 years, 8 months ago (2017-04-07 04:10:56 UTC) #15
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 04:46:36 UTC) #18
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0ac6602eb8a9152a55bf395bac11...

Powered by Google App Engine
This is Rietveld 408576698