android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java - Issue 2803853006: WebView: prefer ContentUrlConstants over literals

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java

Issue 2803853006: WebView: prefer ContentUrlConstants over literals (Closed)

Patch Set: Revert changes to system webview shell Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/java/src/org/chromium/android_webview/AwContents.java ('k') | android_webview/java/src/org/chromium/android_webview/AwWebContentsObserver.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java

diff --git a/android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java b/android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java

index ea6ce33cb4d6b5e2bc8b7bd45db22735ae1418b4..549caaf82a23b03d42e19b3c90a9bf2dd4d25d62 100644

--- a/android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java

+++ b/android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java

@@ -27,6 +27,7 @@ import org.chromium.base.ContentUriUtils;

import org.chromium.base.ThreadUtils;

import org.chromium.content.browser.ContentVideoViewEmbedder;

import org.chromium.content_public.browser.InvalidateTypes;

+import org.chromium.content_public.common.ContentUrlConstants;

import org.chromium.content_public.common.ResourceRequestBody;

/**

@@ -261,7 +262,7 @@ class AwWebContentsDelegateAdapter extends AwWebContentsDelegate {

// Hint the client to show the last committed url, as it may be unsafe to show

// the pending entry.

String url = mAwContents.getLastCommittedUrl();

- url = TextUtils.isEmpty(url) ? "about:blank" : url;

+ url = TextUtils.isEmpty(url) ? ContentUrlConstants.ABOUT_BLANK_DISPLAY_URL : url;

mContentsClient.getCallbackHelper().postSynthesizedPageLoadingForUrlBarUpdate(url);

}