android_webview/javatests/src/org/chromium/android_webview/test/AwLegacyQuirksTest.java - Issue 2803853006: WebView: prefer ContentUrlConstants over literals

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/AwLegacyQuirksTest.java

Issue 2803853006: WebView: prefer ContentUrlConstants over literals (Closed)

Patch Set: Revert changes to system webview shell Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java ('k') | android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/javatests/src/org/chromium/android_webview/test/AwLegacyQuirksTest.java

diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/AwLegacyQuirksTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/AwLegacyQuirksTest.java

index 72f0f200172e3bad287eb9d05da408a8d1ced6b9..11325d0dd9e511679dca47122fc97831f5cea120 100644

--- a/android_webview/javatests/src/org/chromium/android_webview/test/AwLegacyQuirksTest.java

+++ b/android_webview/javatests/src/org/chromium/android_webview/test/AwLegacyQuirksTest.java

@@ -12,6 +12,7 @@ import org.chromium.android_webview.AwSettings;

import org.chromium.base.annotations.SuppressFBWarnings;

import org.chromium.base.test.util.CallbackHelper;

import org.chromium.base.test.util.Feature;

+import org.chromium.content_public.common.ContentUrlConstants;

import org.chromium.ui.display.DisplayAndroid;

import java.util.Locale;

@@ -132,7 +133,7 @@ public class AwLegacyQuirksTest extends AwTestBase {

settings.setJavaScriptEnabled(true);

- loadUrlSync(awContents, onPageFinishedHelper, "about:blank");

+ loadUrlSync(awContents, onPageFinishedHelper, ContentUrlConstants.ABOUT_BLANK_DISPLAY_URL);

DisplayAndroid displayAndroid = DisplayAndroid.getNonMultiDisplay(

getInstrumentation().getTargetContext());