Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2488)

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/ClientOnPageFinishedTest.java

Issue 2803853006: WebView: prefer ContentUrlConstants over literals (Closed)
Patch Set: Revert changes to system webview shell Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/javatests/src/org/chromium/android_webview/test/ClientOnPageFinishedTest.java
diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/ClientOnPageFinishedTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/ClientOnPageFinishedTest.java
index 22be6afd7d0615fe37e3a0cb4202d87538caf398..8e39f2e63c84189b3a68b3f7a3213cd29bb4dbb0 100644
--- a/android_webview/javatests/src/org/chromium/android_webview/test/ClientOnPageFinishedTest.java
+++ b/android_webview/javatests/src/org/chromium/android_webview/test/ClientOnPageFinishedTest.java
@@ -13,6 +13,7 @@ import org.chromium.base.test.util.Feature;
import org.chromium.base.test.util.FlakyTest;
import org.chromium.base.test.util.RetryOnFailure;
import org.chromium.content.browser.test.util.TestCallbackHelperContainer;
+import org.chromium.content_public.common.ContentUrlConstants;
import org.chromium.net.test.util.TestWebServer;
import java.util.concurrent.CountDownLatch;
@@ -73,7 +74,7 @@ public class ClientOnPageFinishedTest extends AwTestBase {
@Override
public void onPageFinished(String url) {
- if (mAllowAboutBlank && "about:blank".equals(url)) {
+ if (mAllowAboutBlank && ContentUrlConstants.ABOUT_BLANK_DISPLAY_URL.equals(url)) {
super.onPageFinished(url);
return;
}
@@ -107,7 +108,7 @@ public class ClientOnPageFinishedTest extends AwTestBase {
// we load a valid page. Since callbacks arrive sequentially, this will ensure that
// any extra calls of onPageFinished / onReceivedError will arrive to our client.
testContentsClient.setAllowAboutBlank();
- loadUrlSync(mAwContents, onPageFinishedHelper, "about:blank");
+ loadUrlSync(mAwContents, onPageFinishedHelper, ContentUrlConstants.ABOUT_BLANK_DISPLAY_URL);
}
@MediumTest

Powered by Google App Engine
This is Rietveld 408576698