android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientVisitedHistoryTest.java - Issue 2803853006: WebView: prefer ContentUrlConstants over literals

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientVisitedHistoryTest.java

Issue 2803853006: WebView: prefer ContentUrlConstants over literals (Closed)

Patch Set: Revert changes to system webview shell Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/java/src/org/chromium/android_webview/AwWebContentsObserver.java ('k') | android_webview/javatests/src/org/chromium/android_webview/test/AwContentsGarbageCollectionTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientVisitedHistoryTest.java

diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientVisitedHistoryTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientVisitedHistoryTest.java

index d0a814a9dde653e30b4de81a35b0a4e04ea21433..04b8906faf66f74d63c3f52a8c5fa8c5d6c33767 100644

--- a/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientVisitedHistoryTest.java

+++ b/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientVisitedHistoryTest.java

@@ -11,6 +11,7 @@ import org.chromium.android_webview.AwContents;

import org.chromium.android_webview.test.TestAwContentsClient.DoUpdateVisitedHistoryHelper;

import org.chromium.base.test.util.CallbackHelper;

import org.chromium.base.test.util.Feature;

+import org.chromium.content_public.common.ContentUrlConstants;

import org.chromium.net.test.util.TestWebServer;

/**

@@ -134,7 +135,7 @@ public class AwContentsClientVisitedHistoryTest extends AwTestBase {

final int callCount = visitedHistoryHelper.getCallCount();

AwTestContainerView testView = createAwTestContainerViewOnMainSync(mContentsClient);

AwContents awContents = testView.getAwContents();

- loadUrlAsync(awContents, "about:blank");

+ loadUrlAsync(awContents, ContentUrlConstants.ABOUT_BLANK_DISPLAY_URL);

visitedHistoryHelper.waitForCallback(callCount);

assertNotNull(visitedHistoryHelper.getCallback());