android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java - Issue 2803853006: WebView: prefer ContentUrlConstants over literals

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java

Issue 2803853006: WebView: prefer ContentUrlConstants over literals (Closed)

Patch Set: Revert changes to system webview shell Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/javatests/src/org/chromium/android_webview/test/AwLegacyQuirksTest.java ('k') | android_webview/javatests/src/org/chromium/android_webview/test/ClientOnPageFinishedTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java

diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java

index 5690913b28db867a00613113b9d1c4e1accd382a..a262b338fe943f4ce4cc3c2bc6d0c92b2d1eeac2 100644

--- a/android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java

+++ b/android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java

@@ -38,6 +38,7 @@ import org.chromium.base.test.util.UrlUtils;

import org.chromium.content.browser.test.util.DOMUtils;

import org.chromium.content.browser.test.util.HistoryUtils;

import org.chromium.content_public.browser.WebContents;

+import org.chromium.content_public.common.ContentUrlConstants;

import org.chromium.net.test.EmbeddedTestServer;

import org.chromium.net.test.util.TestWebServer;

import org.chromium.ui.display.DisplayAndroid;

@@ -2935,7 +2936,8 @@ public class AwSettingsTest extends AwTestBase {

JSUtils.executeJavaScriptAndWaitForResult(this, awContents,

client.getOnEvaluateJavaScriptResultHelper(),

"window.emptyDocumentPersistenceTest = true;");

- loadUrlSync(awContents, client.getOnPageFinishedHelper(), "about:blank");

+ loadUrlSync(awContents, client.getOnPageFinishedHelper(),

+ ContentUrlConstants.ABOUT_BLANK_DISPLAY_URL);

String result = JSUtils.executeJavaScriptAndWaitForResult(this, awContents,

client.getOnEvaluateJavaScriptResultHelper(),

"window.emptyDocumentPersistenceTest ? 'set' : 'not set';");