Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(653)

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/ClientOnPageStartedTest.java

Issue 2803853006: WebView: prefer ContentUrlConstants over literals (Closed)
Patch Set: Revert changes to system webview shell Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/javatests/src/org/chromium/android_webview/test/ClientOnPageStartedTest.java
diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/ClientOnPageStartedTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/ClientOnPageStartedTest.java
index 1c30e88d23d57991381d0e4ec5b944a236995567..63e7cc0d47d3cb7b6da22faf27831ffda7f05a9e 100644
--- a/android_webview/javatests/src/org/chromium/android_webview/test/ClientOnPageStartedTest.java
+++ b/android_webview/javatests/src/org/chromium/android_webview/test/ClientOnPageStartedTest.java
@@ -9,6 +9,7 @@ import android.support.test.filters.MediumTest;
import org.chromium.android_webview.AwContents;
import org.chromium.base.test.util.Feature;
import org.chromium.content.browser.test.util.TestCallbackHelperContainer;
+import org.chromium.content_public.common.ContentUrlConstants;
/**
* Tests for the ContentViewClient.onPageStarted() method.
@@ -65,7 +66,7 @@ public class ClientOnPageStartedTest extends AwTestBase {
@Override
public void onPageStarted(String url) {
- if (mAllowAboutBlank && "about:blank".equals(url)) {
+ if (mAllowAboutBlank && ContentUrlConstants.ABOUT_BLANK_DISPLAY_URL.equals(url)) {
super.onPageStarted(url);
return;
}
@@ -102,6 +103,6 @@ public class ClientOnPageStartedTest extends AwTestBase {
// we load a valid page. Since callbacks arrive sequentially, this will ensure that
// any extra calls of onPageStarted / onReceivedError will arrive to our client.
testContentsClient.setAllowAboutBlank();
- loadUrlSync(mAwContents, onPageFinishedHelper, "about:blank");
+ loadUrlSync(mAwContents, onPageFinishedHelper, ContentUrlConstants.ABOUT_BLANK_DISPLAY_URL);
}
}

Powered by Google App Engine
This is Rietveld 408576698