android_webview/java/src/org/chromium/android_webview/AwWebContentsObserver.java - Issue 2803853006: WebView: prefer ContentUrlConstants over literals

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/java/src/org/chromium/android_webview/AwWebContentsObserver.java

Issue 2803853006: WebView: prefer ContentUrlConstants over literals (Closed)

Patch Set: Revert changes to system webview shell Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java ('k') | android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientVisitedHistoryTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/java/src/org/chromium/android_webview/AwWebContentsObserver.java

diff --git a/android_webview/java/src/org/chromium/android_webview/AwWebContentsObserver.java b/android_webview/java/src/org/chromium/android_webview/AwWebContentsObserver.java

index cd5e29b973e7d15e0b3e6cdf644df7ae93bc8189..56d09a962cf4bae084ac30ab5b2ad55ca0b0a443 100644

--- a/android_webview/java/src/org/chromium/android_webview/AwWebContentsObserver.java

+++ b/android_webview/java/src/org/chromium/android_webview/AwWebContentsObserver.java

@@ -8,6 +8,7 @@ import org.chromium.android_webview.AwContents.VisualStateCallback;

import org.chromium.base.ThreadUtils;

import org.chromium.content_public.browser.WebContents;

import org.chromium.content_public.browser.WebContentsObserver;

+import org.chromium.content_public.common.ContentUrlConstants;

import org.chromium.net.NetError;

import org.chromium.ui.base.PageTransition;

@@ -57,7 +58,7 @@ public class AwWebContentsObserver extends WebContentsObserver {

@Override

public void didStopLoading(String validatedUrl) {

- if (validatedUrl.length() == 0) validatedUrl = "about:blank";

+ if (validatedUrl.length() == 0) validatedUrl = ContentUrlConstants.ABOUT_BLANK_DISPLAY_URL;

AwContentsClient client = getClientIfNeedToFireCallback(validatedUrl);

if (client != null && validatedUrl.equals(mLastDidFinishLoadUrl)) {

client.getCallbackHelper().postOnPageFinished(validatedUrl);