android_webview/javatests/src/org/chromium/android_webview/test/ClientOnReceivedError2Test.java - Issue 2803853006: WebView: prefer ContentUrlConstants over literals

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/ClientOnReceivedError2Test.java

Issue 2803853006: WebView: prefer ContentUrlConstants over literals (Closed)

Patch Set: Revert changes to system webview shell Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/javatests/src/org/chromium/android_webview/test/ClientOnPageStartedTest.java ('k') | android_webview/javatests/src/org/chromium/android_webview/test/GeolocationTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/javatests/src/org/chromium/android_webview/test/ClientOnReceivedError2Test.java

diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/ClientOnReceivedError2Test.java b/android_webview/javatests/src/org/chromium/android_webview/test/ClientOnReceivedError2Test.java

index ef0d19fc090478c62babbde6012dd3c55af50c00..510b49d9e1e58cb7eb4abf137757e87de2b8abdf 100644

--- a/android_webview/javatests/src/org/chromium/android_webview/test/ClientOnReceivedError2Test.java

+++ b/android_webview/javatests/src/org/chromium/android_webview/test/ClientOnReceivedError2Test.java

@@ -15,6 +15,7 @@ import org.chromium.android_webview.test.util.AwTestTouchUtils;

import org.chromium.android_webview.test.util.CommonResources;

import org.chromium.base.test.util.Feature;

import org.chromium.content.browser.test.util.TestCallbackHelperContainer;

+import org.chromium.content_public.common.ContentUrlConstants;

import org.chromium.net.test.util.TestWebServer;

import java.util.concurrent.CountDownLatch;

@@ -265,8 +266,8 @@ public class ClientOnReceivedError2Test extends AwTestBase {

final String iframeUrl = baseUrl + "does_not_exist.html";

final String pageHtml = CommonResources.makeHtmlPageFrom(

"", "<iframe src='" + iframeUrl + "' />");

- loadDataWithBaseUrlSync(mAwContents, mContentsClient.getOnPageFinishedHelper(),

- pageHtml, "text/html", false, baseUrl, "about:blank");

+ loadDataWithBaseUrlSync(mAwContents, mContentsClient.getOnPageFinishedHelper(), pageHtml,

+ "text/html", false, baseUrl, ContentUrlConstants.ABOUT_BLANK_DISPLAY_URL);

TestAwContentsClient.OnReceivedError2Helper onReceivedError2Helper =

mContentsClient.getOnReceivedError2Helper();

@@ -291,7 +292,7 @@ public class ClientOnReceivedError2Test extends AwTestBase {

final String pageHtml = CommonResources.makeHtmlPageFrom(

"", "<iframe src='" + iframeUrl + "' />");

loadDataWithBaseUrlSync(mAwContents, mContentsClient.getOnPageFinishedHelper(), pageHtml,

- "text/html", false, baseUrl, "about:blank");

+ "text/html", false, baseUrl, ContentUrlConstants.ABOUT_BLANK_DISPLAY_URL);

TestAwContentsClient.OnReceivedError2Helper onReceivedError2Helper =

mContentsClient.getOnReceivedError2Helper();