android_webview/javatests/src/org/chromium/android_webview/test/crash/VisualStateCallbackTest.java - Issue 2803853006: WebView: prefer ContentUrlConstants over literals

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/crash/VisualStateCallbackTest.java

Issue 2803853006: WebView: prefer ContentUrlConstants over literals (Closed)

Patch Set: Revert changes to system webview shell Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/javatests/src/org/chromium/android_webview/test/LoadDataWithBaseUrlTest.java ('k') | android_webview/test/shell/src/org/chromium/android_webview/shell/AwShellActivity.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/javatests/src/org/chromium/android_webview/test/crash/VisualStateCallbackTest.java

diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/crash/VisualStateCallbackTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/crash/VisualStateCallbackTest.java

index 0f3ef8d00ca529d7f71d304e0134095c432c9282..447dd49c303e84b90f7bec0e382fd365bc7b576e 100644

--- a/android_webview/javatests/src/org/chromium/android_webview/test/crash/VisualStateCallbackTest.java

+++ b/android_webview/javatests/src/org/chromium/android_webview/test/crash/VisualStateCallbackTest.java

@@ -27,6 +27,7 @@ import org.chromium.base.test.util.CallbackHelper;

import org.chromium.base.test.util.CommandLineFlags;

import org.chromium.base.test.util.Feature;

import org.chromium.base.test.util.parameter.ParameterizedTest;

+import org.chromium.content_public.common.ContentUrlConstants;

import java.util.concurrent.TimeUnit;

@@ -180,7 +181,7 @@ public class VisualStateCallbackTest extends AwTestBase {

insertVisualStateCallbackOnUIThread(mAwContents, vsImpl.requestId(), vsImpl);

VisualStateCallbackHelper vsCallbackHelper = mAwContents.getVisualStateCallbackHelper();

int callCount = vsCallbackHelper.getCallCount();

- loadUrlAsync(mAwContents, "about:blank");

+ loadUrlAsync(mAwContents, ContentUrlConstants.ABOUT_BLANK_DISPLAY_URL);

vsCallbackHelper.waitForCallback(

callCount, 1, CallbackHelper.WAIT_TIMEOUT_SECONDS, TimeUnit.SECONDS);

assertEquals(callCount + 1, vsCallbackHelper.getCallCount());